From 77595b1f5f911e9f115bd61214c14ae11d809cf3 Mon Sep 17 00:00:00 2001 From: Michael Gartner Date: Mon, 24 Feb 2025 20:05:52 -0600 Subject: [PATCH 01/13] re enable --- apps/roam/src/components/settings/GeneralSettings.tsx | 4 +--- apps/roam/src/utils/configPageTabs.ts | 6 ++---- apps/roam/src/utils/initializeObserversAndListeners.ts | 8 ++++---- 3 files changed, 7 insertions(+), 11 deletions(-) diff --git a/apps/roam/src/components/settings/GeneralSettings.tsx b/apps/roam/src/components/settings/GeneralSettings.tsx index 32c970bdc..79abf505d 100644 --- a/apps/roam/src/components/settings/GeneralSettings.tsx +++ b/apps/roam/src/components/settings/GeneralSettings.tsx @@ -31,13 +31,11 @@ const DiscourseGraphHome = () => { /> [ { title: "overlay", Panel: FlagPanel, - // description: - // "Whether to overlay discourse context information over node references", - description: "Currently disabled. Being reworked.", - disabled: true, + description: + "Whether to overlay discourse context information over node references", options: { onChange: (val) => { onPageRefObserverChange((s) => overlayPageRefHandler(s, args))(val); diff --git a/apps/roam/src/utils/initializeObserversAndListeners.ts b/apps/roam/src/utils/initializeObserversAndListeners.ts index 5d8f865a6..c4e442450 100644 --- a/apps/roam/src/utils/initializeObserversAndListeners.ts +++ b/apps/roam/src/utils/initializeObserversAndListeners.ts @@ -21,6 +21,7 @@ import { addPageRefObserver, getPageRefObserversSize, previewPageRefHandler, + overlayPageRefHandler, } from "~/utils/pageRefObserverHandlers"; import getDiscourseNodes from "~/utils/getDiscourseNodes"; import { OnloadArgs } from "roamjs-components/types"; @@ -104,10 +105,9 @@ export const initObservers = async ({ }); if (isFlagEnabled("preview")) addPageRefObserver(previewPageRefHandler); - // TODO: grammar overlay being refactored - // if (isFlagEnabled("grammar.overlay")) { - // addPageRefObserver((s) => overlayPageRefHandler(s, onloadArgs)); - // } + if (isFlagEnabled("grammar.overlay")) { + addPageRefObserver((s) => overlayPageRefHandler(s, onloadArgs)); + } if (!!getPageRefObserversSize()) enablePageRefObserver(); const { pageUid: configPageUid, observer: configPageObserver } = From 569f9a0385c4487e7e1594fce2ca3e0c74d7b52b Mon Sep 17 00:00:00 2001 From: Michael Gartner Date: Tue, 25 Feb 2025 13:27:56 -0600 Subject: [PATCH 02/13] optimize getting specification conditions --- apps/roam/src/utils/getDiscourseNodes.ts | 27 +++++++++++++++--------- apps/roam/src/utils/parseQuery.ts | 2 +- 2 files changed, 18 insertions(+), 11 deletions(-) diff --git a/apps/roam/src/utils/getDiscourseNodes.ts b/apps/roam/src/utils/getDiscourseNodes.ts index 8751db5d7..2879ee76a 100644 --- a/apps/roam/src/utils/getDiscourseNodes.ts +++ b/apps/roam/src/utils/getDiscourseNodes.ts @@ -2,9 +2,9 @@ import getSettingValueFromTree from "roamjs-components/util/getSettingValueFromT import getSubTree from "roamjs-components/util/getSubTree"; import discourseConfigRef from "./discourseConfigRef"; import getDiscourseRelations from "./getDiscourseRelations"; -import parseQuery from "./parseQuery"; +import { roamNodeToCondition } from "./parseQuery"; import { Condition } from "./types"; -import { InputTextNode } from "roamjs-components/types"; +import { InputTextNode, RoamBasicNode } from "roamjs-components/types"; export const excludeDefaultNodes = (node: DiscourseNode) => { return node.backedBy !== "default"; @@ -64,22 +64,29 @@ const DEFAULT_NODES: DiscourseNode[] = [ }, ]; +const getSpecification = (children: RoamBasicNode[] | undefined) => { + const spec = getSubTree({ + tree: children, + key: "specification", + }); + const scratchNode = getSubTree({ tree: spec.children, key: "scratch" }); + const conditionsNode = getSubTree({ + tree: scratchNode.children, + key: "conditions", + }); + const specs = conditionsNode.children.map(roamNodeToCondition); + return specs; +}; + const getDiscourseNodes = (relations = getDiscourseRelations()) => { const configuredNodes = Object.entries(discourseConfigRef.nodes) .map(([type, { text, children }]): DiscourseNode => { - const spec = getSubTree({ - tree: children, - key: "specification", - }); - const specTree = spec.children; return { format: getSettingValueFromTree({ tree: children, key: "format" }), text, shortcut: getSettingValueFromTree({ tree: children, key: "shortcut" }), type, - specification: !!getSubTree({ tree: specTree, key: "enabled" }).uid - ? parseQuery(spec.uid).conditions - : [], + specification: getSpecification(children), backedBy: "user", canvasSettings: Object.fromEntries( getSubTree({ tree: children, key: "canvas" }).children.map( diff --git a/apps/roam/src/utils/parseQuery.ts b/apps/roam/src/utils/parseQuery.ts index e7268ed15..4c16639d4 100644 --- a/apps/roam/src/utils/parseQuery.ts +++ b/apps/roam/src/utils/parseQuery.ts @@ -4,7 +4,7 @@ import getSubTree from "roamjs-components/util/getSubTree"; import createBlock from "roamjs-components/writes/createBlock"; import { Column, Condition, Selection } from "./types"; -const roamNodeToCondition = ({ +export const roamNodeToCondition = ({ uid, children, text, From 54c65b2dda39e4d8eaf97a3888e530ee5ab2c091 Mon Sep 17 00:00:00 2001 From: Michael Gartner Date: Tue, 25 Feb 2025 14:23:02 -0600 Subject: [PATCH 03/13] pageRefObserver fix and cleanup --- apps/roam/src/utils/findDiscourseNode.ts | 16 +++++++++++----- apps/roam/src/utils/pageRefObserverHandlers.ts | 13 ------------- 2 files changed, 11 insertions(+), 18 deletions(-) diff --git a/apps/roam/src/utils/findDiscourseNode.ts b/apps/roam/src/utils/findDiscourseNode.ts index ec28d654d..aaaf73ef3 100644 --- a/apps/roam/src/utils/findDiscourseNode.ts +++ b/apps/roam/src/utils/findDiscourseNode.ts @@ -3,10 +3,16 @@ import matchDiscourseNode from "./matchDiscourseNode"; const discourseNodeTypeCache: Record = {}; -const findDiscourseNode = (uid = "", nodes = getDiscourseNodes()) => - typeof discourseNodeTypeCache[uid] !== "undefined" - ? discourseNodeTypeCache[uid] - : (discourseNodeTypeCache[uid] = - nodes.find((n) => matchDiscourseNode({ ...n, uid })) || false); +const findDiscourseNode = (uid = "", nodes = getDiscourseNodes()) => { + if (typeof discourseNodeTypeCache[uid] !== "undefined") { + return discourseNodeTypeCache[uid]; + } + const matchingNode = nodes.find((node) => + matchDiscourseNode({ ...node, uid }), + ); + + discourseNodeTypeCache[uid] = matchingNode || false; + return discourseNodeTypeCache[uid]; +}; export default findDiscourseNode; diff --git a/apps/roam/src/utils/pageRefObserverHandlers.ts b/apps/roam/src/utils/pageRefObserverHandlers.ts index be173ee58..ea20cde67 100644 --- a/apps/roam/src/utils/pageRefObserverHandlers.ts +++ b/apps/roam/src/utils/pageRefObserverHandlers.ts @@ -83,19 +83,6 @@ export const onPageRefObserverChange = export const addPageRefObserver = (handler: (s: HTMLSpanElement) => void) => { pageRefObservers.add(handler); - if (pageRefObservers.size === 1) enablePageRefObserver(); -}; - -export const removePageRefObserver = ( - handler: (s: HTMLSpanElement) => void, -) => { - pageRefObservers.delete(handler); - if (pageRefObservers.size === 0) disablePageRefObserver(); -}; - -export const clearPageRefObservers = () => { - disablePageRefObserver(); - pageRefObservers.clear(); }; export const getPageRefObserversSize = () => pageRefObservers.size; From 13e7f90a73ff1a0c45c562660828651f39049c05 Mon Sep 17 00:00:00 2001 From: Michael Gartner Date: Tue, 25 Feb 2025 14:23:50 -0600 Subject: [PATCH 04/13] no results fix --- apps/roam/src/components/DiscourseContext.tsx | 31 ++++++++++--------- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/apps/roam/src/components/DiscourseContext.tsx b/apps/roam/src/components/DiscourseContext.tsx index 151daabe5..0f3f57b2a 100644 --- a/apps/roam/src/components/DiscourseContext.tsx +++ b/apps/roam/src/components/DiscourseContext.tsx @@ -324,32 +324,35 @@ export const ContextContent = ({ uid, results }: Props) => { const [loading, setLoading] = useState(true); const debouncedLoading = useDebounce(loading, 150); + const addLabels = useCallback((result: DiscourseContextResults[number]) => { + setRawQueryResults((prev) => ({ + ...prev, + [result.label]: { + label: result.label, + results: { + ...(prev[result.label]?.results || {}), + ...result.results, + }, + }, + })); + }, []); + const onRefresh = useCallback(() => { setRawQueryResults({}); getDiscourseContextResults({ uid, - onResult: (result) => { - setRawQueryResults((prev) => ({ - ...prev, - [result.label]: { - label: result.label, - results: { - ...(prev[result.label]?.results || {}), - ...result.results, - }, - }, - })); - }, + onResult: addLabels, }).finally(() => setLoading(false)); - }, [uid, setRawQueryResults, setLoading]); + }, [uid, setRawQueryResults, setLoading, addLabels]); useEffect(() => { if (!results) { onRefresh(); } else { + results.forEach(addLabels); setLoading(false); } - }, [onRefresh, results, setLoading]); + }, [onRefresh, results, setLoading, loading, addLabels]); const [tabId, setTabId] = useState(0); const [groupByTarget, setGroupByTarget] = useState(false); return queryResults.length ? ( From 6c53cd7f46be5a93c78ea75fd9dbfe76c819ec82 Mon Sep 17 00:00:00 2001 From: Michael Gartner Date: Tue, 25 Feb 2025 14:24:32 -0600 Subject: [PATCH 05/13] results view menu icons fix --- apps/roam/src/components/DiscourseContext.tsx | 6 ++--- apps/roam/src/components/QueryDrawer.tsx | 11 +++++--- .../components/results-view/ResultsView.tsx | 25 +++++++------------ 3 files changed, 19 insertions(+), 23 deletions(-) diff --git a/apps/roam/src/components/DiscourseContext.tsx b/apps/roam/src/components/DiscourseContext.tsx index 0f3f57b2a..c11f4b214 100644 --- a/apps/roam/src/components/DiscourseContext.tsx +++ b/apps/roam/src/components/DiscourseContext.tsx @@ -273,7 +273,7 @@ const ContextTab = ({ columns={columns} onRefresh={onRefresh} header={ - <> +

{r.label} - +

} /> ); @@ -409,7 +409,7 @@ export const ContextContent = ({ uid, results }: Props) => { /> ) : ( -
No discourse relations found.
+
No discourse relations found.
); }; diff --git a/apps/roam/src/components/QueryDrawer.tsx b/apps/roam/src/components/QueryDrawer.tsx index 7ae5c2477..3f11740a5 100644 --- a/apps/roam/src/components/QueryDrawer.tsx +++ b/apps/roam/src/components/QueryDrawer.tsx @@ -87,15 +87,18 @@ const SavedQuery = ({ }} > {error} +

+
{error}
+

) : ( - <> +

{isEditingLabel ? ( )} -
+
{!isSavedToPage && ( <> @@ -185,7 +188,7 @@ const SavedQuery = ({ )}
- +

) } onDeleteQuery={onDelete} diff --git a/apps/roam/src/components/results-view/ResultsView.tsx b/apps/roam/src/components/results-view/ResultsView.tsx index f121f685a..5c6752fbd 100644 --- a/apps/roam/src/components/results-view/ResultsView.tsx +++ b/apps/roam/src/components/results-view/ResultsView.tsx @@ -226,6 +226,7 @@ type ResultsViewComponent = (props: { header?: React.ReactNode; results: Result[]; hideResults?: boolean; + hideMenu?: boolean; preventSavingSettings?: boolean; onEdit?: () => void; onDeleteQuery?: () => void; @@ -267,6 +268,7 @@ const ResultsView: ResultsViewComponent = ({ header, results, hideResults = false, + hideMenu = false, preventSavingSettings = false, onEdit, onDeleteQuery, @@ -315,7 +317,8 @@ const ResultsView: ResultsViewComponent = ({ const [columnFilters, setColumnFilters] = useState(settings.columnFilters); const [searchFilter, setSearchFilter] = useState(settings.searchFilter); const [showInterface, setShowInterface] = useState(settings.showInterface); - const [showMenuIcons, setShowMenuIcons] = useState(false); + const [revealMenuIcons, setRevealMenuIcons] = useState(false); + const hideMenuIcons = hideMenu || (!revealMenuIcons && !showInterface); const { allProcessedResults, paginatedResults } = useMemo(() => { return postProcessResults(results, { @@ -410,8 +413,8 @@ const ResultsView: ResultsViewComponent = ({
setShowMenuIcons(true)} - onMouseLeave={() => setShowMenuIcons(false)} + onMouseEnter={() => setRevealMenuIcons(true)} + onMouseLeave={() => setRevealMenuIcons(false)} > {isEditSearchFilter && (
+ {header}
{onRefresh && ( @@ -1134,18 +1138,7 @@ const ResultsView: ResultsViewComponent = ({ } />
- {header && ( -

- {header} -

- )} + {!hideResults && ( <> {results.length !== 0 ? ( From 78d6c0d7e0f284cf7f7abe0107adff38a686149a Mon Sep 17 00:00:00 2001 From: Michael Gartner Date: Tue, 25 Feb 2025 14:25:19 -0600 Subject: [PATCH 06/13] overlay ui tweak --- .../components/DiscourseContextOverlay.tsx | 54 ++++++++++--------- 1 file changed, 29 insertions(+), 25 deletions(-) diff --git a/apps/roam/src/components/DiscourseContextOverlay.tsx b/apps/roam/src/components/DiscourseContextOverlay.tsx index a458dfa84..804c5e2b4 100644 --- a/apps/roam/src/components/DiscourseContextOverlay.tsx +++ b/apps/roam/src/components/DiscourseContextOverlay.tsx @@ -1,4 +1,4 @@ -import { Button, Popover, Position, Tooltip } from "@blueprintjs/core"; +import { Button, Icon, Popover, Position, Tooltip } from "@blueprintjs/core"; import React, { useCallback, useEffect, useMemo, useState } from "react"; import ReactDOM from "react-dom"; import { ContextContent } from "./DiscourseContext"; @@ -38,6 +38,7 @@ const getOverlayInfo = (tag: string, id: string): Promise => { if (cache[tag]) return Promise.resolve(cache[tag]); const relations = getDiscourseRelations(); const nodes = getDiscourseNodes(relations); + return new Promise((resolve) => { const triggerNow = overlayQueue.length === 0; overlayQueue.push({ @@ -161,38 +162,34 @@ const DiscourseContextOverlay = ({ tag, id }: { tag: string; id: string }) => { autoFocus={false} content={
- - -
} target={ } position={Position.BOTTOM} /> @@ -211,14 +208,21 @@ const Wrapper = ({ parent, tag }: { parent: HTMLElement; tag: string }) => { ) : ( ); }; From 850424319b0a45cacf65012f286f10dea8f0e727 Mon Sep 17 00:00:00 2001 From: Michael Gartner Date: Wed, 26 Feb 2025 13:54:57 -0600 Subject: [PATCH 07/13] move overlay to personal settings --- .../settings/HomePersonalSettings.tsx | 39 +++++++++++++++---- .../roam/src/components/settings/Settings.tsx | 2 +- apps/roam/src/utils/configPageTabs.ts | 13 ------- apps/roam/src/utils/discourseConfigRef.ts | 6 +-- .../utils/initializeObserversAndListeners.ts | 2 +- .../roam/src/utils/pageRefObserverHandlers.ts | 15 ++++++- 6 files changed, 48 insertions(+), 29 deletions(-) diff --git a/apps/roam/src/components/settings/HomePersonalSettings.tsx b/apps/roam/src/components/settings/HomePersonalSettings.tsx index f21f5863c..bddf03b24 100644 --- a/apps/roam/src/components/settings/HomePersonalSettings.tsx +++ b/apps/roam/src/components/settings/HomePersonalSettings.tsx @@ -1,16 +1,15 @@ -import React, { useState } from "react"; +import React, { useMemo, useState } from "react"; import { OnloadArgs } from "roamjs-components/types"; -import { Label, InputGroup } from "@blueprintjs/core"; +import { Label, InputGroup, Checkbox } from "@blueprintjs/core"; import Description from "roamjs-components/components/Description"; import { DEFAULT_CANVAS_PAGE_FORMAT } from "~/index"; import { NodeMenuTriggerComponent } from "../DiscourseNodeMenu"; +import { getOverlayHandler } from "~/utils/pageRefObserverHandlers"; +import { onPageRefObserverChange } from "~/utils/pageRefObserverHandlers"; const CANVAS_PAGE_FORMAT_KEY = "canvas-page-format"; -const HomePersonalSettings = ({ - extensionAPI, -}: { - extensionAPI: OnloadArgs[`extensionAPI`]; -}) => { +const HomePersonalSettings = ({ onloadArgs }: { onloadArgs: OnloadArgs }) => { + const extensionAPI = onloadArgs.extensionAPI; const getInitCanvasPage = () => { const savedFormat = extensionAPI.settings.get( CANVAS_PAGE_FORMAT_KEY, @@ -22,6 +21,8 @@ const HomePersonalSettings = ({ extensionAPI.settings.set(CANVAS_PAGE_FORMAT_KEY, e); setCanvasPage(e); }; + const overlayHandler = getOverlayHandler(onloadArgs); + return (
+ { + const target = e.target as HTMLInputElement; + extensionAPI.settings.set( + "discourse-context-overlay", + target.checked, + ); + + onPageRefObserverChange(overlayHandler)(target.checked); + }} + labelElement={ + <> + Overlay + + + } + />
); }; diff --git a/apps/roam/src/components/settings/Settings.tsx b/apps/roam/src/components/settings/Settings.tsx index 511582ccf..ef63a2678 100644 --- a/apps/roam/src/components/settings/Settings.tsx +++ b/apps/roam/src/components/settings/Settings.tsx @@ -93,7 +93,7 @@ export const SettingsDialog = ({ id="discourse-graph-home-personal" title="Home" className="overflow-y-auto" - panel={} + panel={} /> [ component: DiscourseRelationConfigPanel, }, } as Field, - // @ts-ignore - { - title: "overlay", - Panel: FlagPanel, - description: - "Whether to overlay discourse context information over node references", - options: { - onChange: (val) => { - onPageRefObserverChange((s) => overlayPageRefHandler(s, args))(val); - }, - }, - } as Field, ], }, { diff --git a/apps/roam/src/utils/discourseConfigRef.ts b/apps/roam/src/utils/discourseConfigRef.ts index 8be543837..650d9b904 100644 --- a/apps/roam/src/utils/discourseConfigRef.ts +++ b/apps/roam/src/utils/discourseConfigRef.ts @@ -23,7 +23,6 @@ type FormattedConfigTree = { trigger: StringSetting; preview: BooleanSetting; disableSidebarOpen: BooleanSetting; - overlay: BooleanSetting; export: ExportConfigWithUids; }; @@ -54,10 +53,7 @@ export const getFormattedConfigTree = (): FormattedConfigTree => { tree: configTreeRef.tree, text: "preview", }), - overlay: getUidAndBooleanSetting({ - tree: grammarNode?.children || [], - text: "overlay", - }), + export: getExportSettingsAndUids(), }; }; diff --git a/apps/roam/src/utils/initializeObserversAndListeners.ts b/apps/roam/src/utils/initializeObserversAndListeners.ts index c4e442450..ae2303a8a 100644 --- a/apps/roam/src/utils/initializeObserversAndListeners.ts +++ b/apps/roam/src/utils/initializeObserversAndListeners.ts @@ -105,7 +105,7 @@ export const initObservers = async ({ }); if (isFlagEnabled("preview")) addPageRefObserver(previewPageRefHandler); - if (isFlagEnabled("grammar.overlay")) { + if (onloadArgs.extensionAPI.settings.get("discourse-context-overlay")) { addPageRefObserver((s) => overlayPageRefHandler(s, onloadArgs)); } if (!!getPageRefObserversSize()) enablePageRefObserver(); diff --git a/apps/roam/src/utils/pageRefObserverHandlers.ts b/apps/roam/src/utils/pageRefObserverHandlers.ts index ea20cde67..5717aee6f 100644 --- a/apps/roam/src/utils/pageRefObserverHandlers.ts +++ b/apps/roam/src/utils/pageRefObserverHandlers.ts @@ -10,7 +10,17 @@ const pageRefObserverRef: { current?: MutationObserver } = { current: undefined, }; -export const overlayPageRefHandler = (s: HTMLSpanElement, args: OnloadArgs) => { +// Public handler (stable reference) +let cachedHandler: ((s: HTMLSpanElement) => void) | undefined; +export const getOverlayHandler = (onloadArgs: OnloadArgs) => + cachedHandler || + (cachedHandler = (s: HTMLSpanElement) => + overlayPageRefHandler(s, onloadArgs)); + +export const overlayPageRefHandler = ( + s: HTMLSpanElement, + onloadArgs: OnloadArgs, +) => { if (s.parentElement && !s.parentElement.closest(".rm-page-ref")) { const tag = s.getAttribute("data-tag") || @@ -25,7 +35,7 @@ export const overlayPageRefHandler = (s: HTMLSpanElement, args: OnloadArgs) => { discourseOverlayRender({ parent, tag: tag.replace(/\\"/g, '"'), - onloadArgs: args, + onloadArgs, }); if (s.hasAttribute("data-tag")) { s.appendChild(parent); @@ -54,6 +64,7 @@ export const previewPageRefHandler = (s: HTMLSpanElement) => { s.appendChild(parent); } }; +export const previewHandler = previewPageRefHandler; export const enablePageRefObserver = () => (pageRefObserverRef.current = createHTMLObserver({ From 9d3f67d361e9ad54dc59390bd85632cf25b249ca Mon Sep 17 00:00:00 2001 From: Michael Gartner Date: Wed, 26 Feb 2025 13:55:59 -0600 Subject: [PATCH 08/13] change refs to async.q --- .../src/components/DiscourseContextOverlay.tsx | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/apps/roam/src/components/DiscourseContextOverlay.tsx b/apps/roam/src/components/DiscourseContextOverlay.tsx index 804c5e2b4..b1f1bd887 100644 --- a/apps/roam/src/components/DiscourseContextOverlay.tsx +++ b/apps/roam/src/components/DiscourseContextOverlay.tsx @@ -47,9 +47,16 @@ const getOverlayInfo = (tag: string, id: string): Promise => { end: 0, mid: 0, queued: new Date().valueOf(), - callback() { + async callback() { const self = this; const start = (self.start = new Date().valueOf()); + // @ts-ignore + const queryResult = await window.roamAlphaAPI.data.async.q( + `[:find ?a :where [?b :node/title "${normalizePageTitle( + tag, + )}"] [?a :block/refs ?b]]`, + ); + const refs = queryResult.length; return getDiscourseContextResults({ uid: getPageUidByPageTitle(tag), nodes, @@ -58,11 +65,8 @@ const getOverlayInfo = (tag: string, id: string): Promise => { self.mid = new Date().valueOf(); const output = (cache[tag] = { results, - refs: window.roamAlphaAPI.data.fast.q( - `[:find ?a :where [?b :node/title "${normalizePageTitle( - tag, - )}"] [?a :block/refs ?b]]`, - ).length, + + refs, }); const runTime = (self.end = new Date().valueOf() - start); setTimeout(() => { From 9390d3c233e725648fbcbd20cfb69e952a2bfa66 Mon Sep 17 00:00:00 2001 From: Michael Gartner Date: Wed, 26 Feb 2025 13:56:07 -0600 Subject: [PATCH 09/13] remove loading spinner --- apps/roam/src/components/DiscourseContextOverlay.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/apps/roam/src/components/DiscourseContextOverlay.tsx b/apps/roam/src/components/DiscourseContextOverlay.tsx index b1f1bd887..05dbbf3ed 100644 --- a/apps/roam/src/components/DiscourseContextOverlay.tsx +++ b/apps/roam/src/components/DiscourseContextOverlay.tsx @@ -177,7 +177,6 @@ const DiscourseContextOverlay = ({ tag, id }: { tag: string; id: string }) => {
Date: Wed, 26 Feb 2025 19:54:59 -0600 Subject: [PATCH 11/13] rm icons from placeholder --- apps/roam/src/components/DiscourseContextOverlay.tsx | 2 -- 1 file changed, 2 deletions(-) diff --git a/apps/roam/src/components/DiscourseContextOverlay.tsx b/apps/roam/src/components/DiscourseContextOverlay.tsx index 05dbbf3ed..fee01d104 100644 --- a/apps/roam/src/components/DiscourseContextOverlay.tsx +++ b/apps/roam/src/components/DiscourseContextOverlay.tsx @@ -214,8 +214,6 @@ const Wrapper = ({ parent, tag }: { parent: HTMLElement; tag: string }) => { small id={id} minimal - icon={"diagram-tree"} - rightIcon={"link"} className={"roamjs-discourse-context-overlay"} disabled={true} > From 32e7bbb7d4e106f36800e2959f9edf68f73e522c Mon Sep 17 00:00:00 2001 From: Michael Gartner Date: Thu, 6 Mar 2025 16:05:21 -0600 Subject: [PATCH 12/13] . --- apps/roam/src/components/settings/HomePersonalSettings.tsx | 2 +- apps/roam/src/utils/pageRefObserverHandlers.ts | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/apps/roam/src/components/settings/HomePersonalSettings.tsx b/apps/roam/src/components/settings/HomePersonalSettings.tsx index bddf03b24..5a56046fe 100644 --- a/apps/roam/src/components/settings/HomePersonalSettings.tsx +++ b/apps/roam/src/components/settings/HomePersonalSettings.tsx @@ -1,4 +1,4 @@ -import React, { useMemo, useState } from "react"; +import React, { useState } from "react"; import { OnloadArgs } from "roamjs-components/types"; import { Label, InputGroup, Checkbox } from "@blueprintjs/core"; import Description from "roamjs-components/components/Description"; diff --git a/apps/roam/src/utils/pageRefObserverHandlers.ts b/apps/roam/src/utils/pageRefObserverHandlers.ts index 5717aee6f..f5438d33f 100644 --- a/apps/roam/src/utils/pageRefObserverHandlers.ts +++ b/apps/roam/src/utils/pageRefObserverHandlers.ts @@ -64,7 +64,6 @@ export const previewPageRefHandler = (s: HTMLSpanElement) => { s.appendChild(parent); } }; -export const previewHandler = previewPageRefHandler; export const enablePageRefObserver = () => (pageRefObserverRef.current = createHTMLObserver({ From 97384477a57767a17b0051167c757207e2e88d03 Mon Sep 17 00:00:00 2001 From: Michael Gartner Date: Thu, 6 Mar 2025 16:13:09 -0600 Subject: [PATCH 13/13] . --- apps/roam/src/index.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/apps/roam/src/index.ts b/apps/roam/src/index.ts index 1316880fe..7c7578768 100644 --- a/apps/roam/src/index.ts +++ b/apps/roam/src/index.ts @@ -51,8 +51,6 @@ export const DEFAULT_CANVAS_PAGE_FORMAT = "Canvas/*"; export default runExtension(async (onloadArgs) => { const isEncrypted = window.roamAlphaAPI.graph.isEncrypted; const isOffline = window.roamAlphaAPI.graph.type === "offline"; - console.log("isEncrypted", isEncrypted); - console.log("isOffline", isOffline); if (!isEncrypted && !isOffline) { initPostHog(); posthog.capture("Extension Loaded", {