New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Member): add flags #918
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly documentation stuff, looks good to me overall.
It's worth mentioning that editing flags isn't documented (neither is the permission requirement); still, it works as expected and the client does it this way too.
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com> Signed-off-by: Victor <67214928+Victorsitou@users.noreply.github.com>
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com> Signed-off-by: Victor <67214928+Victorsitou@users.noreply.github.com>
…snake into feat/member-flags
Should we add it, though? |
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com> Signed-off-by: Victor <67214928+Victorsitou@users.noreply.github.com>
Seems fine. If anything, the edit parameter wouldn't break, it'd just be ignored; I sincerely doubt they'll change anything about it though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
Summary
discord/discord-api-docs#5874
Checklist
task lint
task pyright