Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Member): add flags #918

Merged
merged 19 commits into from Jan 26, 2023
Merged

Conversation

Victorsitou
Copy link
Member

Summary

discord/discord-api-docs#5874

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running task lint
    • I have type-checked the code by running task pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Victorsitou Victorsitou added t: enhancement New feature t: api support Support of Discord API features s: needs review Issue/PR is awaiting reviews labels Jan 25, 2023
@Victorsitou Victorsitou added this to the disnake v2.8 milestone Jan 25, 2023
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly documentation stuff, looks good to me overall.

It's worth mentioning that editing flags isn't documented (neither is the permission requirement); still, it works as expected and the client does it this way too.

disnake/flags.py Outdated Show resolved Hide resolved
disnake/flags.py Outdated Show resolved Hide resolved
disnake/flags.py Outdated Show resolved Hide resolved
disnake/member.py Outdated Show resolved Hide resolved
disnake/member.py Outdated Show resolved Hide resolved
docs/api.rst Show resolved Hide resolved
disnake/flags.py Show resolved Hide resolved
disnake/member.py Outdated Show resolved Hide resolved
disnake/member.py Outdated Show resolved Hide resolved
disnake/member.py Outdated Show resolved Hide resolved
Victorsitou and others added 10 commits January 25, 2023 21:06
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: Victor <67214928+Victorsitou@users.noreply.github.com>
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: Victor <67214928+Victorsitou@users.noreply.github.com>
@Victorsitou
Copy link
Member Author

It's worth mentioning that editing flags isn't documented (neither is the permission requirement); still, it works as expected and the client does it this way too.

Should we add it, though?

disnake/member.py Outdated Show resolved Hide resolved
disnake/permissions.py Outdated Show resolved Hide resolved
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: Victor <67214928+Victorsitou@users.noreply.github.com>
@shiftinv
Copy link
Member

It's worth mentioning that editing flags isn't documented (neither is the permission requirement); still, it works as expected and the client does it this way too.

Should we add it, though?

Seems fine. If anything, the edit parameter wouldn't break, it'd just be ignored; I sincerely doubt they'll change anything about it though.

Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@shiftinv shiftinv merged commit af5a8dd into DisnakeDev:master Jan 26, 2023
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: api support Support of Discord API features t: enhancement New feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants