Upcoming Kernel 6.2 breaks compilation #394
Comments
Crashdummyy
changed the title
crashdummy@crashphyrus ~/.../github/evdi devel ● git diff
diff --git a/module/evdi_fb.c b/module/evdi_fb.c
index 6b367fe..05a08d5 100644
--- a/module/evdi_fb.c
+++ b/module/evdi_fb.c
@@ -405,7 +405,7 @@ static int evdifb_create(struct drm_fb_helper *helper,
fb = &efbdev->efb.base;
efbdev->helper.fb = fb;
- efbdev->helper.fbdev = info;
+ efbdev->helper.info = info;
strcpy(info->fix.id, "evdidrmfb");
@@ -459,8 +459,8 @@ static void evdi_fbdev_destroy(__always_unused struct drm_device *dev,
{
struct fb_info *info;
- if (efbdev->helper.fbdev) {
- info = efbdev->helper.fbdev;
+ if (efbdev->helper.info) {
+ info = efbdev->helper.info;
unregister_framebuffer(info);
if (info->cmap.len)
fb_dealloc_cmap(&info->cmap);
@@ -537,10 +537,10 @@ void evdi_fbdev_unplug(struct drm_device *dev)
return;
efbdev = evdi->fbdev;
- if (efbdev->helper.fbdev) {
+ if (efbdev->helper.info) {
struct fb_info *info;
- info = efbdev->helper.fbdev;
+ info = efbdev->helper.info;
#if KERNEL_VERSION(5, 6, 0) <= LINUX_VERSION_CODE || defined(EL8)
unregister_framebuffer(info);
#else
crashdummy@crashphyrus ~/.../github/evdi devel ● |
|
Same issue here with Ubuntu 22.10 with kernel |
Original patch was suggested by Crashdummyy. Fixes: DisplayLink#394 Fixes: DisplayLink#384 Signed-off-by: listout <listout@protonmail.com>
Original patch was suggested by Crashdummyy. Since commit 9877d8f6bc374912b08dfe862cddbb78b395a5ef feild fbdev has been renamed to info in struct drm_fb_helper. Fixes: DisplayLink#394 Fixes: DisplayLink#384 Signed-off-by: listout <listout@protonmail.com>
Original patch was suggested by Crashdummyy. Since commit 9877d8f6bc374912b08dfe862cddbb78b395a5ef feild fbdev has been renamed to info in struct drm_fb_helper. Fixes: DisplayLink#394 Fixes: DisplayLink#384 Fixes: DisplayLink#402 Signed-off-by: listout <listout@protonmail.com>
Since commit 9877d8f6bc374912b08dfe862cddbb78b395a5ef feild fbdev has been renamed to info in struct drm_fb_helper. Fixes: DisplayLink#402 Fixes: DisplayLink#394 Fixes: DisplayLink#384 Signed-off-by: listout <listout@protonmail.com>
|
The provided patch no longer applies for me, but applying those changes manually worked for me. |
Glad its working again. |
|
Looking for this too downgraded my kernel for now -.- |
|
patch worked for me: ubuntu variant. Linux pop-os 6.2.0-76060200-generic |
|
works for me: Pop!_OS 22.04 LTS x86_64 and 6.1.11-76060111-generic this forum guided me so posting for reference: https://www.displaylink.org/forum/showthread.php?p=94837 Many thanks to all contributors to this kernel releases are infrequent enough that I forget about displaylink always breaking, but often enough that it's really annoying XD |
Since commit 9877d8f6bc374912b08dfe862cddbb78b395a5ef feild fbdev has been renamed to info in struct drm_fb_helper. Fixes: DisplayLink#402 Fixes: DisplayLink#394 Fixes: DisplayLink#384 Signed-off-by: listout <listout@protonmail.com>
|
The changes in the second comment is present in commit a47ded875c20 made 2023-01-03 (but pushed in March?). And since that commit was included in release v1.13.0 made a month ago I guess this issue could be closed? |
|
totally forgot about that. |
I am currently testing
6.2.0-0.rc2.20230105git41c03ba9beea.20.vanilla.1.fc37.x86_64and it apparently evdi cant be built using it anymore, as evdi_fb.c cant compile anymore.make.log
Since This commit from 2 month ago
The drm_device is not exposed anymore
The text was updated successfully, but these errors were encountered: