New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoSublime Crashing Sublime Text 3: MacOS X #911

Open
gyant opened this Issue Feb 4, 2019 · 6 comments

Comments

Projects
None yet
3 participants
@gyant
Copy link

gyant commented Feb 4, 2019

I'm running into a very strange issue with the GoSublime plugin.

Currently, my setup is a MacBook Pro connected to 2 monitors. I have the laptop up on a stand with the clamshell open so from left to right my displays are MacBook Pro display -> 24" Asus 1080p (monitor 1) -> 24" Asus 1080p (monitor 2).

When I start new instances of Sublime (using subl), the new application instance pops up on my MacBook Pro display.

So, let's say I have an instance of Sublime open on monitor 1 and I want to open a new instance of Sublime for a different project than my first instance. I go to a terminal on monitor 2 and type subl ..

If my MacBook Pro display has a maximized application (in this case Slack) in focus, Sublime will go completely unresponsive. I have to force quit the application and start all over again.

However, if on my MacBook Pro Display I've changed to a workspace that's not a maximized application, I can spin up as many new instances of Sublime as I want and Sublime won't seize up.

The problem is, there's nothing in the logs to indicate any code errors. I do know, however, that if I disable the GoSublime package, this problem does not occur at all.

Sublime Text 3 is 3.1.1
GoSublime: 66dc145
Margo: r18.11.28-1_go1.11.5
Go: 1.11.5

Is there any additional information I can provide to help narrow down the cause of this strange behavior?

@DisposaBoy

This comment has been minimized.

Copy link
Owner

DisposaBoy commented Feb 5, 2019

  • Try upgrading Sublime Text. Newer (dev) versions have other stability fixes so might also fix this.

  • You can try killing the margo.sublime, margo.sh and gosublime.margo processes instead of Sublime Text. That should rule out or point to margo being the trigger.

  • You can also try partially disabling any IPC communication by setting the enabled languages to an empty string. Change mg.AllLangs to "" in margo.go / https://margo.sh/s/extension-example#L49

    EDIT: after changing this you will need to restart Sublime Text for any changes in margo.go to take effect

@gyant

This comment has been minimized.

Copy link
Author

gyant commented Feb 5, 2019

Thank you for the suggestions! Upgrading to the dev build changes the behavior of how new instances of Sublime start up. Instead of keeping the maximized application on-screen, it actually moves you to the workspace where the new window is created.

I'm not getting freezing issues anymore! Thank you very much for the assist! Issue resolved.

@gyant gyant closed this Feb 5, 2019

@seripap

This comment has been minimized.

Copy link

seripap commented Feb 6, 2019

I'm having this issue as well with GoSublime 66dc145, Sublime Text 3189

Get's stuck after this command:

GoSublime r18.11.28-1: _before.init()
GoSublime r18.11.28-1: gs.init()
GoSublime r18.11.28-1: sh.init()

Works perfectly when I revert to 9be2a67

GoSublime r18.11.28-1: _before.init()
GoSublime r18.11.28-1: gs.init()
GoSublime r18.11.28-1: sh.init()
GoSublime r18.11.28-1 sh: using shell env GOPATH=/Users/root/go
GoSublime r18.11.28-1 sh: using shell env GOROOT=/usr/local/Cellar/go/1.11.4/libexec
...
GoSublime r18.11.28-1: margo.init()
GoSublime r18.11.28-1: mg9.init()
[21:00:29] margo: agent#007: starting
GoSublime r18.11.28-1: _after.init()

** 2019-02-05 21:00:29.661729 **:
GoSublime init r18.11.28-1 (0.009s)
@gyant

This comment has been minimized.

Copy link
Author

gyant commented Feb 6, 2019

I actually ran into another crash today but it's happening much less frequently. I'll give that commit hash a try and see if I get any different behavior.

@DisposaBoy

This comment has been minimized.

Copy link
Owner

DisposaBoy commented Feb 9, 2019

@seripap Are you able to reliably reproduce this? the most likely cause would be b1a490f but I can't really see how. Are you able to reproduce it there too?

Did you try my suggestions in #911 (comment)?

@DisposaBoy DisposaBoy reopened this Feb 9, 2019

@seripap

This comment has been minimized.

Copy link

seripap commented Feb 10, 2019

@DisposaBoy- I did initially try killing the margo processes but Sublime was still stuck- however, changing mg.AllLangs to "" seemed to have fixed the loop crash.

After margo successfully loaded, I changed it back to mg.AllLangs, restarted and then it seemed like it continued to boot & work afterwards. Not entirely sure why the magical 9be2a67 was working without having to do this workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment