From 863c0703ca2118275dd22d007d23b81ba721e198 Mon Sep 17 00:00:00 2001 From: Tom Tang Date: Fri, 7 Jul 2023 04:30:33 +0000 Subject: [PATCH 1/3] ci: do not fail-fast when building SpiderMonkey --- .github/workflows/test-and-publish.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/test-and-publish.yaml b/.github/workflows/test-and-publish.yaml index 2a987316..5c8694a7 100644 --- a/.github/workflows/test-and-publish.yaml +++ b/.github/workflows/test-and-publish.yaml @@ -23,6 +23,7 @@ defaults: jobs: build-spidermonkey-unix: strategy: + fail-fast: false matrix: # Use Ubuntu 20.04 / macOS 12 + Python 3.10 to build SpiderMonkey os: [ 'ubuntu-20.04', 'macos-12', 'm2ci' ] From 91cfd116a777784d37fb65e16ae35d74989c12cf Mon Sep 17 00:00:00 2001 From: Tom Tang Date: Fri, 7 Jul 2023 04:39:15 +0000 Subject: [PATCH 2/3] ci: setup Poetry when building SpiderMonkey --- .github/workflows/test-and-publish.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/workflows/test-and-publish.yaml b/.github/workflows/test-and-publish.yaml index 5c8694a7..d6881851 100644 --- a/.github/workflows/test-and-publish.yaml +++ b/.github/workflows/test-and-publish.yaml @@ -42,6 +42,11 @@ jobs: ./_spidermonkey_install/* key: spidermonkey-${{ runner.os }}-${{ runner.arch }} lookup-only: true # skip download + - name: Setup Poetry + if: ${{ steps.cache-spidermonkey.outputs.cache-hit != 'true' }} + uses: snok/install-poetry@v1 + with: + version: 1.5.1 - name: Build spidermonkey if: ${{ steps.cache-spidermonkey.outputs.cache-hit != 'true' }} run: ./setup.sh @@ -57,6 +62,11 @@ jobs: ./_spidermonkey_install/* key: spidermonkey-${{ runner.os }}-${{ runner.arch }} lookup-only: true # skip download + - name: Setup Poetry + if: ${{ steps.cache-spidermonkey.outputs.cache-hit != 'true' }} + uses: snok/install-poetry@v1 + with: + version: 1.5.1 - name: Install dependencies if: ${{ steps.cache-spidermonkey.outputs.cache-hit != 'true' }} shell: powershell From 97944735bb538d0e06f0793dbe0e5b0c08f1618a Mon Sep 17 00:00:00 2001 From: Tom Tang Date: Fri, 7 Jul 2023 04:42:23 +0000 Subject: [PATCH 3/3] chore: allow `brew update` in setup.sh to fail --- setup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.sh b/setup.sh index a2e80aef..6c10d0c6 100755 --- a/setup.sh +++ b/setup.sh @@ -11,7 +11,7 @@ if [[ "$OSTYPE" == "linux-gnu"* ]]; then # Linux sudo apt-get update --yes sudo apt-get install cmake doxygen graphviz llvm g++ pkg-config m4 wget --yes elif [[ "$OSTYPE" == "darwin"* ]]; then # macOS - brew update + brew update || true # allow failure brew install cmake doxygen graphviz pkg-config wget coreutils # `coreutils` installs the `realpath` command elif [[ "$OSTYPE" == "msys"* ]]; then # Windows echo "Dependencies are not going to be installed automatically on Windows."