Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for AppVeyor Miniconda3 Tests #743

Merged
merged 11 commits into from Feb 13, 2019

Conversation

Projects
None yet
2 participants
@bbengfort
Copy link
Member

commented Feb 12, 2019

This PR is a workaround to the issue described in #744 by using the "Previous Visual Studio 2015" image rather than the current CI image.

See discussion here.

@bbengfort bbengfort added the review label Feb 12, 2019

@bbengfort bbengfort force-pushed the bbengfort:appveyor branch from 8e7e006 to 6b8eecd Feb 13, 2019

bbengfort added some commits Feb 13, 2019

@bbengfort bbengfort force-pushed the bbengfort:appveyor branch from 7184d42 to 229bf9f Feb 13, 2019

@bbengfort bbengfort changed the title Fix AppVeyor Tests Workaround for AppVeyor Minconda3 Tests Feb 13, 2019

@rebeccabilbro rebeccabilbro changed the title Workaround for AppVeyor Minconda3 Tests Workaround for AppVeyor Miniconda3 Tests Feb 13, 2019

@rebeccabilbro
Copy link
Collaborator

left a comment

Thank you so much @bbengfort for investigating and discovering this workaround so that we can keep miniconda in our CI pipeline. Excited to get this merged in so that we can get all those other PRs out of purgatory 💃

@rebeccabilbro rebeccabilbro merged commit 2ff414f into DistrictDataLabs:develop Feb 13, 2019

4 checks passed

LGTM analysis: Python No code changes detected
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage increased (+0.1%) to 87.797%
Details

@rebeccabilbro rebeccabilbro removed the review label Feb 13, 2019

@bbengfort bbengfort deleted the bbengfort:appveyor branch Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.