Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add store.override() #1102

Closed
pkarw opened this issue Apr 28, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@pkarw
Copy link
Collaborator

commented Apr 28, 2018

It would be nice to have an option to re-map the Vuex action used by core/store module in the VS

I see it as a method to extend the Vuex.store used by VS:-
store.override('product/list', (payload) => {})
or
store.override('product/list', 'mystore/list')

Then we need to override dispatch() method to make the usage of such a map. Of course, we'll be needing a dispatchOriginal() to execute the original action and allow the extension developers to modify the result

Such a "cheap IoC" could be of course generating some issues - like never be sure which exact method will be executed when few extensions will override some basic actions. Although it's still kind of useful option to modify the ways data is loaded from ES / other sources - without modifying the core.

@filrak

This comment has been minimized.

Copy link
Collaborator

commented May 7, 2018

If noone will take it I can start development next week. I'll just rethink the approach to address this issue "Such a "cheap IoC" could be of course generating some issues - like never be sure which exact method will be executed when few extensions will override some basic actions."

@pkarw pkarw added this to the 1.0FINAL milestone May 10, 2018

@pkarw pkarw added the vs-hackathon label May 10, 2018

@pkarw pkarw modified the milestones: 1.0FINAL, 1.1 May 10, 2018

@mercs600

This comment has been minimized.

@gopkumargopi

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2018

@pkarw please assign this to me if my PR addressed this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.