Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot edit previous steps in checkout #2438

Closed
smorincaron opened this issue Feb 14, 2019 · 4 comments

Comments

@smorincaron
Copy link

commented Feb 14, 2019

Current behavior

First two steps might result in not being editable when going back and forth in steps
capture d ecran 2019-02-14 a 15 46 19

Expected behavior

We should still be able to edit the previous steps

Steps to reproduce the issue

  1. Add product to cart and proceed to checkout page
  2. Fill first and second step (even third if you want to bug second step as well)
  3. From step 3, Click on "Edit personal details"
  4. Click on "Edit shipping"

The first step is no longer available for edit.

Repository

Related to isFilled variable
https://github.com/DivanteLtd/vue-storefront/blob/master/core/modules/checkout/components/PersonalDetails.ts

Can you handle fixing this bug by yourself?

NO

Environment details

Additional information

Related to isFilled variable
https://github.com/DivanteLtd/vue-storefront/blob/master/core/modules/checkout/components/PersonalDetails.ts
The value isFilled only changed on step edit or next step button.
Should be changed to ensure if edit is clicked on another step, the edited step should be completed or we need to save the step before editing a new one.

@filrak filrak self-assigned this Feb 16, 2019

@filrak

This comment has been minimized.

Copy link
Collaborator

commented Feb 16, 2019

I'll take care of this one

@filrak filrak added the bug label Feb 16, 2019

@patzick patzick added this to the 1.9 milestone Feb 20, 2019

@patzick patzick closed this Feb 20, 2019

@patzick patzick modified the milestones: 1.9, 1.8.3 Feb 26, 2019

@ArturDivante

This comment has been minimized.

Copy link
Collaborator

commented Feb 27, 2019

Bug was fixed for step 1. But I am still able to recreate bug for step 2:

Steps to reproduce:

  1. Add product to cart and proceed to checkout page
  2. Fill first, second and third step.
  3. From step 4, click "Edit Shipping"
  4. Click "Edit Payment"

Step 2 is grayed and impossible to edit directly.
step2bugged

Problem can be bypassed by going back to step one and continue from there, but still it should be posiible to navigate between steps freely.

@ArturDivante ArturDivante reopened this Feb 27, 2019

@pkarw pkarw assigned patzick and unassigned filrak Feb 27, 2019

@patzick patzick referenced this issue Feb 27, 2019
2 of 2 tasks complete
@patzick

This comment has been minimized.

Copy link
Collaborator

commented Feb 27, 2019

im leaving need confirmation label, but this should be tested after merging #2511

@patzick

This comment has been minimized.

Copy link
Collaborator

commented Feb 27, 2019

Merged and deployed - ready for tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.