Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Missing links for basics/configuration #2490

Closed
daksamit opened this issue Feb 23, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@daksamit
Copy link
Contributor

commented Feb 23, 2019

Current behavior

Following links are redirect to 404 under documentation - 'Configuration file explained'.

  1. catalog - 'GraphQL' section
  2. core/store/lib/multistore.ts - 'Default store code' section
  3. The same for core/store/lib/multistore.ts and core/store/lib/taxcalc.ts - 'Store views' sections
  4. All links at 'Entities', 'Cart', 'Products' sections are incorrect.
  5. And again 'Taxes' for core/store/lib/taxcalc.ts
  6. Last section 'Query' for ' format of the query has been described' here link

Expected behavior

Some links are fixable, but I'm not sure if all of them.

Steps to reproduce the issue

Click links at documentation

Repository

@vue-storefront/docs

Can you handle fixing this bug by yourself?

YES

Environment details

  • Browser: Google Chrome Version 71.0.3578.98 (Official Build) (64-bit)
  • OS: Mint 18.2 sonya

Additional information

I can fix most of them, but i'm not sure about 'core/store/lib/taxcalc.ts', Did you mean tax.ts.

And last question: src/extensions under 'Mailchimp section' - should it be src/extensions ?

@daksamit daksamit changed the title [docs] Missing links for basic configuration [docs] Missing links for basics/configuration Feb 23, 2019

@pkarw

This comment has been minimized.

Copy link
Collaborator

commented Feb 23, 2019

Cool! Please go on with the fixes.

Answers:

  1. Yes, tax.ts
  2. Yes, however it would be great to eventually port these extensions to modules (from 1.6 extensions are deprecated)

@daksamit daksamit referenced this issue Feb 23, 2019

Merged

bugfix/2490 docs missing links #2491

4 of 5 tasks complete
@daksamit

This comment has been minimized.

Copy link
Contributor Author

commented Feb 23, 2019

And at documentation, what links should be replaced for:

  1. 'Please check the core/service-worker/order.js for reference' redirects to core/service-worker/order.js - Orders section

Moreover, maybe not this issue related, but PULL_REQUEST_TEMPLATE under 'Contribution and currently important rules acceptance' has incorrect links.
I suggest following links:

- [ ] I read and followed [contribution rules](https://docs.vuestorefront.io/guide/basics/contributing.html)
- [ ] I read the [TypeScript Action Plan](https://docs.vuestorefront.io/guide/basics/typescript.html) and adjusted my PR according to it
- [ ] I read about [Vue Storefront Modules](https://docs.vuestorefront.io/guide/modules/introduction.html) and I am aware that every new feature should be a module

@pkarw pkarw closed this Feb 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.