Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quantity numbers are added like strings in offline mode #2517

Closed
ArturDivante opened this issue Feb 28, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@ArturDivante
Copy link
Collaborator

commented Feb 28, 2019

Current behavior

Adding another products result in summing their quantity digits instead of values (see video).

Expected behavior

Product quantities should be summed correctly in offline mode.

Steps to reproduce the issue

  1. Open https://test.storefrontcloud.io/ and then any category page
  2. Turn to offline mode
  3. Open product page and add some quantity to cart
  4. Open another product page and again add some quantity to cart

offline strings

Repository

test.storefrontcloud.io

Can you handle fixing this bug by yourself?

no

Environment details

  • Browser: many
  • OS: win10

Additional information

Sometimes problem is tricky to reproduce. Trying with few diffrent products (as described in steps) makes it easier to recreate.

Important update!

I just noticed, that problem in some way occurs also in online mode.

  1. Adding 2nd product (with any quantity) to the cart briefly results in displaying incorrect number on the cart icon - but it gets recalculated correctly within a second
  2. If we quickly click "add to cart" button few times, incorrectly high quantities might really be added to cart. Example:
    We set quantity number to 5 and then quickly click "add to cart" few times, we may add 55 items instead of 5,10,15 etc. If only stock supply allow for that, we will add incorrectly high number of products to the cart

@ArturDivante ArturDivante changed the title Quanity numbers are added like strings in offline mode Quantity numbers are added like strings in offline mode Feb 28, 2019

@ArturDivante

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 1, 2019

Important update! - I just noticed, that problem in some way occurs also in online mode.

  1. Adding 2nd product (with any quantity) to the cart briefly results in displaying incorrect number on the cart icon - but it gets recalculated correctly within a second
  2. If we quickly click "add to cart" button few times, incorrectly high quantities might really be added to cart. Example:
    We set quantity number to 5 and then quickly click "add to cart" few times, we may add 55 items instead of 5,10,15 etc. If only stock supply allow for that, we will add incorrectly high number of products to the cart

@pkarw pkarw referenced this issue Mar 2, 2019

Merged

Bugfix/2517 #2526

1 of 5 tasks complete

@pkarw pkarw added the bug label Mar 2, 2019

@pkarw pkarw closed this Mar 2, 2019

@patzick patzick added this to the 1.8.3 milestone Mar 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.