Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect hover activity on the 'filter by categories' in the search view on mobile #2783

Closed
GabiDivante opened this issue Apr 24, 2019 · 2 comments

Comments

Projects
None yet
5 participants
@GabiDivante
Copy link
Collaborator

commented Apr 24, 2019

Current behavior

On mobile devices after clicking on the chosen filter, and then clicking on it to switch it off, the hover remains visible. This may confuse the user which filters are currently being applied.
Peek 2019-04-24 10-52

Expected behavior

After clicking on the chosen filter to switch it off, hover should disappear.

Steps to reproduce the issue

The problem appears on https://demo.storefrontcloud.io/ and https://next.storefrontcloud.io

  1. Go to https://demo.storefrontcloud.io/ on a mobile device
  2. Open search window by clicking on the loupe
  3. Type a word, for example, 'top'
  4. Click on any filter
  5. Unclick chosen filter

Can you handle fixing this bug by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

  • Browser: Chrome, Firefox
  • OS: Android, v7 on Samsung Galaxy S8
@idodidodi

This comment has been minimized.

Copy link
Collaborator

commented Apr 28, 2019

I am working on it

@idodidodi idodidodi referenced this issue Apr 28, 2019

Merged

Bugfix/#2783 #2832

6 of 8 tasks complete

patzick added a commit that referenced this issue Apr 29, 2019

@patzick

This comment has been minimized.

Copy link
Collaborator

commented Apr 29, 2019

Thanks @idodidodi! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.