Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/2449 menu not working on static pages #2456

Merged
merged 4 commits into from Feb 20, 2019

Conversation

Projects
None yet
3 participants
@filrak
Copy link
Collaborator

commented Feb 19, 2019

Related issues

closes #2449
closes #2441

Short description and why it's useful

We were fetching menu data only on Home so it wasn't working on any other page if accessed directly from the URL. I updated Vue to v2.6 and used native serverPrefetch to fetch sidebar menu data into SSR context right in the root component.

@filrak filrak changed the base branch from master to develop Feb 19, 2019

Show resolved Hide resolved src/themes/default/App.vue Outdated
Show resolved Hide resolved src/themes/default/App.vue Outdated
@pkarw

This comment has been minimized.

Copy link
Collaborator

commented Feb 19, 2019

I like this solution. We’re aiming at lean/dummy components so adding data prefetch shouldn’t be a general rule of thumb but I believe that layout is good place

@filrak filrak changed the title WIP: Bugfix/2449 Bugfix/2449 Feb 19, 2019

@filrak

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 19, 2019

@pkarw @patzick it's ready for CR

@filrak filrak changed the title Bugfix/2449 Bugfix/2449 menu not working on static pages Feb 19, 2019

@pkarw

pkarw approved these changes Feb 20, 2019

@pkarw pkarw merged commit cb534ac into DivanteLtd:develop Feb 20, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pkarw

This comment has been minimized.

Copy link
Collaborator

commented Feb 20, 2019

Done! Thanks @filrak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.