Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/too early breadcrumbs change #2469

Merged
merged 5 commits into from Feb 21, 2019

Conversation

@filrak
Copy link
Collaborator

commented Feb 20, 2019

Related issues

none

Short description and why it's useful

Currently when switching from category to Product page breadcrumbs are changing too early.
I fixed this problem by maiing use of internal breadcrumbs in Product page. there are still some side effects to clean (get rid of global breadcrumbs store) and Changelog to be finished.

also depreciation of @vue-storefront/store needs to be merged

@filrak filrak requested review from pkarw and patzick Feb 20, 2019

@pkarw
pkarw approved these changes Feb 20, 2019

@filrak filrak changed the base branch from develop to docs Feb 21, 2019

@filrak filrak changed the base branch from docs to develop Feb 21, 2019

@pkarw
pkarw approved these changes Feb 21, 2019
Copy link
Collaborator

left a comment

That's fine

@patzick

This comment has been minimized.

Copy link
Collaborator

commented Feb 21, 2019

@filrak is it still WIP?

@filrak filrak changed the title WIP: Bugfix/too early breadcrumbs change Bugfix/too early breadcrumbs change Feb 21, 2019

@filrak

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 21, 2019

nope, just contains #2464 . that needs to be merged first. 2 first files are refering to this PR

filrak added 2 commits Feb 21, 2019

@filrak filrak merged commit 917d026 into DivanteLtd:develop Feb 21, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pkarw

This comment has been minimized.

Copy link
Collaborator

commented Mar 2, 2019

The issue hasn't been yet solved by this PR :( It still exists

pkarw added a commit that referenced this pull request Mar 2, 2019
@pkarw pkarw referenced this pull request Mar 2, 2019
0 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.