Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vue.use memory leaks on SSR #2745

Merged

Conversation

Projects
None yet
2 participants
@patzick
Copy link
Collaborator

commented Apr 17, 2019

Related issues

--

Short description and why it's useful

Fixes memory leaks caused by vue.use on SSR.

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

@patzick patzick requested review from pkarw and filrak Apr 17, 2019

@patzick

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 17, 2019

I added changelog directly to hotfix branch.
1aca4f0

@patzick patzick added this to the 1.8.5 milestone Apr 17, 2019

@pkarw

pkarw approved these changes Apr 17, 2019

@pkarw

This comment has been minimized.

Copy link
Collaborator

commented Apr 17, 2019

Thanks!

@pkarw pkarw merged commit b90fb94 into DivanteLtd:hotfix/v1.8.5 Apr 17, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.