Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find variant with lowest price #3939

Merged
merged 2 commits into from Dec 30, 2019
Merged

find variant with lowest price #3939

merged 2 commits into from Dec 30, 2019

Conversation

gibkigonzo
Copy link
Collaborator

Short Description and Why It's Useful

This is extended find variant method. It returns variant that also has the lowest price. Now when we want to sort products on category page we can see variants that not necessary have the lowest price which may look like sorting doesn't work.

Which Environment This Relates To

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

@pkarw
Copy link
Collaborator

pkarw commented Dec 27, 2019

This is pretty cool! it should be potentially moved to the API layer to optimize the frontend as a part of #3952

@pkarw
Copy link
Collaborator

pkarw commented Dec 27, 2019

... but I'd merge it anyway as #3952 is just a proposition and the overall impact is unknown

@andrzejewsky
Copy link
Contributor

@gibkigonzo is it finished? Can you update the changelog?

@gibkigonzo
Copy link
Collaborator Author

Yes, it's finished and I've updated changelog (sorry 😅 )

@andrzejewsky andrzejewsky merged commit 7d210a7 into vuestorefront:develop Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants