Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Atomic Swaps #123

Closed

Conversation

@ChrisCates
Copy link
Collaborator

commented Sep 16, 2019

Description

Currently, a work in progress pull request to just keep track of progress on Atomic Swaps.
Right now, all that is in the pull request is a regression testing environment for both Divi and Bitcoin.

If you want to check it out, you can run:

git remote add chriscates https://github.com/ChrisCates/Divi
git fetch chriscates
git checkout chriscates/@ChrisCates/AtomicSwaps

Requirements

Review issue #122 for requirements.

Features

Current features currently in PR ready to review.

  • A regression testing environment for Bitcoin and Divi.
@ChrisCates ChrisCates self-assigned this Sep 16, 2019
@99darwin

This comment has been minimized.

Copy link
Collaborator

commented Sep 16, 2019

This looks fine, although, because we will likely have several of these for various features, I think we should add these tests to a specific folder. Whether that's the preexisting test, docker, or some more specific directory.

@ChrisCates

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 16, 2019

Absolutely!
Perhaps test/atomic-swaps/test.Dockerfile would make sense.

Copy link
Collaborator

left a comment

Otherwise the cloning of the bitcoin repo will fail

atomic.test.Dockerfile Outdated Show resolved Hide resolved
atomic.test.Dockerfile Outdated Show resolved Hide resolved
@ChrisCates ChrisCates force-pushed the ChrisCates:@ChrisCates/AtomicSwaps branch from 7d3c071 to 2c6cee5 Sep 16, 2019
@ChrisCates

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 16, 2019

@galpHub, I've added documentation in regards to setting up the regression testing environment for Atomic Swaps.

https://github.com/DiviProject/Divi/blob/2c6cee57aaaf40aea7dab5f960e3d5a26abcc516/test/docker/ATOMIC.ENV.MD

Will be working on some test cases for Atomic Swaps now.

@ChrisCates

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 16, 2019

Just added instructions to configure Atomic Swap code up.
Also added batch and shell scripts to configure for build with golang.

https://github.com/DiviProject/Divi/blob/12db5b517df8961a781f253fcb97ac57ad5c9caa/src/atomic-swap/README.md

@ChrisCates ChrisCates force-pushed the ChrisCates:@ChrisCates/AtomicSwaps branch from 12db5b5 to 698a866 Sep 18, 2019
Refactor and fix Docker env

Added Atomic Swap baseline source

Update Docker test env to configure Golang
@ChrisCates ChrisCates force-pushed the ChrisCates:@ChrisCates/AtomicSwaps branch 3 times, most recently from 0529aeb to 246e9d0 Sep 19, 2019
@ChrisCates ChrisCates force-pushed the ChrisCates:@ChrisCates/AtomicSwaps branch from 246e9d0 to cb0929f Sep 23, 2019
@ChrisCates

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 24, 2019

All work will be migrated to a separate repo: https://github.com/DiviProject/atomic-swaps
We need to do some large scale refactoring to gRPC in order to get this shippable to production.

Closing this PR.

@ChrisCates ChrisCates closed this Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.