Added list delete example and minor changes #401

Merged
merged 1 commit into from Jun 7, 2015

Conversation

Projects
None yet
2 participants
@blossomica
Contributor

blossomica commented Jun 6, 2015

I read the tutorial a couple days ago and noticed it has an example to delete an item in a dictionary but non for the lists and that can leave a newbie wondering what is its equivalent so I added an example of list item removal.

I removed the programmers are lazy mostly because it was not mentioned previously as stated in that sentence and because I believe that, it is a stereotype that can give the wrong impression to some people.

I added an additional explanation on why range does what it does because I felt that was incomplete since the notice told us to notice that but didn't clearly tell us that, that's how that function works. So I tried to kind of fix that.

Also I believe "programmers" sounded better than "computer people" so I changed that too.

I was thinking that it will be nice to have a glossary or dictionary for some of the technical terms on an appendix or at least show newbies on where to get access of a technical dictionary online. I'd like to hear your thoughts on that.

These are my suggested edits I am open to feedback if there is anything that needs changes :)

Thank you.

@aniav

This comment has been minimized.

Show comment
Hide comment
@aniav

aniav Jun 7, 2015

Member

Hey @blossomica! Thank you for the changes, good work done! :)
As for the glossary, we have recently added one, it's the GLOSSARY.md file. The terms defined there should be linked in the text in all occurances. There is just one term now but feel free to add more :)

Member

aniav commented Jun 7, 2015

Hey @blossomica! Thank you for the changes, good work done! :)
As for the glossary, we have recently added one, it's the GLOSSARY.md file. The terms defined there should be linked in the text in all occurances. There is just one term now but feel free to add more :)

aniav added a commit that referenced this pull request Jun 7, 2015

Merge pull request #401 from blossomica/master
Added list delete example and minor changes

@aniav aniav merged commit 3625e20 into DjangoGirls:master Jun 7, 2015

@blossomica

This comment has been minimized.

Show comment
Hide comment
@blossomica

blossomica Jun 8, 2015

Contributor

Oops. I didn't see that. Thanks for bringing it to my attention and also for letting me know I did a good work @aniav :)

I have another question too. In the command line chapter we have move and copy in the table of commands but no extensive example of them previously. Everything else in that table had an extensive example previously done except for those two, and the way they are written in the table (with the line break probably because the table is too small) might confuse someone to think the two lines are two separate commands or that the line break is necessary.

So I was thinking that to avoid confusion in that spot, it either gets removed because it also isn't used anywhere in the tutorial (plus there is a link already linking to additional commands if they are interested) with the pros of making the tutorial a bit shorter or we add in examples for move and copy at work (cons makes the tutorial longer but shows them how move/copy works). I can add in examples if needed but I'd like to see what others think is the best option.

Contributor

blossomica commented Jun 8, 2015

Oops. I didn't see that. Thanks for bringing it to my attention and also for letting me know I did a good work @aniav :)

I have another question too. In the command line chapter we have move and copy in the table of commands but no extensive example of them previously. Everything else in that table had an extensive example previously done except for those two, and the way they are written in the table (with the line break probably because the table is too small) might confuse someone to think the two lines are two separate commands or that the line break is necessary.

So I was thinking that to avoid confusion in that spot, it either gets removed because it also isn't used anywhere in the tutorial (plus there is a link already linking to additional commands if they are interested) with the pros of making the tutorial a bit shorter or we add in examples for move and copy at work (cons makes the tutorial longer but shows them how move/copy works). I can add in examples if needed but I'd like to see what others think is the best option.

@aniav

This comment has been minimized.

Show comment
Hide comment
@aniav

aniav Jun 8, 2015

Member

I believe we should avoid making the tutorial longer at all costs. We already have an issue about the tutorial being too long. From my understanding the additional commands are added there for consistency and because coaches might want to give them as additional excercises, so I would leave them the way they are, or less likely remove them.

Member

aniav commented Jun 8, 2015

I believe we should avoid making the tutorial longer at all costs. We already have an issue about the tutorial being too long. From my understanding the additional commands are added there for consistency and because coaches might want to give them as additional excercises, so I would leave them the way they are, or less likely remove them.

@blossomica

This comment has been minimized.

Show comment
Hide comment
@blossomica

blossomica Jun 8, 2015

Contributor

I see. That's good to know. Thanks for the input on this :)

Contributor

blossomica commented Jun 8, 2015

I see. That's good to know. Thanks for the input on this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment