Fix a bug with long error message#17
Merged
onokonem merged 1 commit intoDjarvur:masterfrom Jan 8, 2021
Merged
Conversation
Member
@takady, would you be able to recreate your commits, or should I recreate your PR myself? |
Use ExactString() because String() returns shortened string if the value is long
takady
force-pushed
the
fix-long-message-bug
branch
from
ae6f159 to
17e30d3
Compare
Contributor
Author
|
@onokonem I just recreated my commit with sign! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I could see
do not define dynamic errors, use wrapped static errors insteadwhen the format string is longer than a certain length, even though it wraps an error properly. That's because of usingString()which returns a shortened string if the value is long. (ref: https://golang.org/pkg/go/constant/#Value)