Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'size' is undefined - IE8 #935

Closed
westonganger opened this issue Feb 3, 2015 · 7 comments

Comments

Projects
None yet
2 participants
@westonganger
Copy link

commented Feb 3, 2015

I am getting the following error on IE8

'size' is undefined Line 1 Char 91726

Could anyone tell me how to patch it

@TheCloudlessSky

This comment has been minimized.

Copy link
Contributor

commented Feb 3, 2015

Can you please provide a sample? What version of Raphael are you using?

@westonganger

This comment has been minimized.

Copy link
Author

commented Feb 3, 2015

I am using v2.1.3. I cant provide a sample unfortunately. But I do know that it works in v2.1.1 the only reason I am upgrading is because the images in the drawing are not showing in the correct position in 2.1.1 on IE8.

@westonganger

This comment has been minimized.

Copy link
Author

commented Feb 3, 2015

I could include a specific portion if you know what I need to look for or grab

@TheCloudlessSky

This comment has been minimized.

Copy link
Contributor

commented Feb 4, 2015

OK - first run your app using the unminified version so you can get a better line number. Then debug the problem from your app and see if you can try and make a reproducible sample. Check out JSFiddle for an easy playground to make samples.

@westonganger

This comment has been minimized.

Copy link
Author

commented Feb 4, 2015

Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.1; WOW64; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; .NET4.0C; .NET4.0E; InfoPath.3; MS-RTC LM 8)
Timestamp: Wed, 4 Feb 2015 02:11:21 UTC

Message: 'size' is undefined
Line: 8125
Char: 9
Code: 0
URI: XXXX/js/raphael-2.1.3.js

@westonganger

This comment has been minimized.

Copy link
Author

commented Feb 4, 2015

it seems to be that on line 8128 on master should be change from
scale: size
to
scale: paperSize
to use the changed variable name on line 8110

@TheCloudlessSky

This comment has been minimized.

Copy link
Contributor

commented Feb 4, 2015

Confirmed. This bug was introduced in 5f08cf5 early in March of 2014. I'll make a PR to fix this.

/cc @tomasAlabes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.