Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Some elements #53

Open
bmaggi opened this issue Jan 6, 2020 · 5 comments
Open

Hide Some elements #53

bmaggi opened this issue Jan 6, 2020 · 5 comments

Comments

@bmaggi
Copy link

@bmaggi bmaggi commented Jan 6, 2020

A nice feature would be to allow filtering/hiding of some elements (and forbid to create these elements)

Some time the map is filled with elements that may not interest the user.

I would be happy to hide:

  • Tree
  • Swimming pool
  • Highway crossing
@m-rey

This comment has been minimized.

Copy link
Contributor

@m-rey m-rey commented Jan 6, 2020

If anything, the user should be able to decide what to hide.
Arbitrarily deciding what elements to hide is not helpful at all.

I, for example, like to add trees to OSM, among other things.

Also, you want to have the possibility of updating the survey date of elements, including trees, swimming pools and highway crossings. Hiding those elements would result in users not checking and thus not updating the survey date. This may result in stale data.

All in all, filtering options would be a nice addition. But the filter definitely needs to be customizable by the user, in my opinion.

@m-rey

This comment has been minimized.

Copy link
Contributor

@m-rey m-rey commented Jan 6, 2020

I also don't understand why the creation of filtered elements should be forbidden.
Can't the element just not be created in the first place instead of actively forbidding its creation?
I don't see any value in restricting node creation based on filters.

@bmaggi

This comment has been minimized.

Copy link
Author

@bmaggi bmaggi commented Jan 7, 2020

Obviously the filter list should be customizable per user. (We all have different point of interest ;) )

I think blocking the creation of filtered elements can prevent some double creation.

For example, if I hide the swimming pool, but at some point want to add one (while forgetting, that it's in the filtering list), it will create a double.

@DoFabien

This comment has been minimized.

Copy link
Owner

@DoFabien DoFabien commented Jan 7, 2020

Creating filters can be very dangerous and can lead to the creation of duplicates.

Sometime, one element can be tagged with differentes keys. If you hide "office=travel_agent",
you can very easily create a duplicate with "shop=travel_agency".

I will try to implement this quickly, but use with caution

@m-rey

This comment has been minimized.

Copy link
Contributor

@m-rey m-rey commented Jan 7, 2020

I agree. Maybe a reminder on the node creation page could be added to tell the user that some nodes are being filtered and thus are not visible. This could help prevent duplicate node creation.

DoFabien added a commit that referenced this issue Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.