Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(unierr): allow nil errors (close #125) #126

Merged
merged 1 commit into from Apr 27, 2021
Merged

feat(unierr): allow nil errors (close #125) #126

merged 1 commit into from Apr 27, 2021

Conversation

GGXXLL
Copy link
Contributor

@GGXXLL GGXXLL commented Apr 26, 2021

No description provided.

@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #126 (9b56828) into master (7192cff) will increase coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
+ Coverage   76.24%   76.45%   +0.20%     
==========================================
  Files          82       82              
  Lines        3077     3083       +6     
==========================================
+ Hits         2346     2357      +11     
+ Misses        544      539       -5     
  Partials      187      187              
Impacted Files Coverage Δ
unierr/error.go 55.64% <100.00%> (+3.95%) ⬆️
dtx/sagas/mysqlstore/mysql_store.go 87.34% <0.00%> (+3.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7192cff...9b56828. Read the comment docs.

@Reasno Reasno self-requested a review April 26, 2021 11:10
@Reasno Reasno merged commit 6c3f812 into DoNewsCode:master Apr 27, 2021
@GGXXLL GGXXLL deleted the unierr_allow_nil_error branch April 27, 2021 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants