Allow use of capybara-email in Capybara 2 #10

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

woahdae commented Aug 30, 2012

Capybara 2 does not define 'url' on the selenium driver, which
previously Capybara::Email::Driver#follow relied on. Fortunately,
Capybara::Session#visit is more robust in Capybara 2, and we can rely on
it to attach the correct full path to relative urls instead of
leveraging the previous 'url' method.

@woahdae woahdae Allow use of capybara-email in Capybara 2
Capybara 2 does not define 'url' on the selenium driver, which
previously Capybara::Email::Driver#follow relied on. Fortunately,
Capybara::Session#visit is more robust in Capybara 2, and we can rely on
it to attach the correct full path to relative urls instead of
leveraging the previous 'url' method.
e2aeda0

This pull request passes (merged e2aeda0 into 37f21ed).

Owner

bcardarella commented Aug 30, 2012

I think the way I'd prefer to handle this is release a 1.0 version of capybara-email and then start a 2.0 version that supports Capybara 2.0. The capybara version dependency in the gemspec can be set to '~> 1 for 1.0 and '~> 2 for 2.0. Thoughts?

woahdae commented Jan 16, 2013

Late to the party, but sounds good!

woahdae deleted the woahdae:capybara2 branch Jan 16, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment