New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar Items Render Oddly #687

Closed
alanjames1987 opened this Issue Feb 15, 2015 · 8 comments

Comments

Projects
None yet
2 participants
@alanjames1987

alanjames1987 commented Feb 15, 2015

When certain items, like switches and badges, are put in the sidebar the placement and rendering of them is very odd. I can't describe this well so I have included a screenshot below.

sidebar

I'm sure there are other items that render oddly but I have not tried all items in the sidebar.

@Dogfalo

This comment has been minimized.

Show comment
Hide comment
@Dogfalo

Dogfalo Feb 15, 2015

Owner

Switches have been fixed, see #683

Owner

Dogfalo commented Feb 15, 2015

Switches have been fixed, see #683

@alanjames1987

This comment has been minimized.

Show comment
Hide comment
@alanjames1987

alanjames1987 Feb 15, 2015

The screenshot above is from 45a809a, the most recent commit at the time of me posting this and one commit after #683 got resolved.

Here is the code I used to create it.

<div class="navbar-fixed">
    <nav>

        <div class="nav-wrapper black">

            <i class="mdi-navigation-menu button-collapse" data-activates="nav-mobile"></i>

            <ul class="right">
                <li><a href="#">Navbar Link</a></li>
            </ul>

            <ul id="nav-mobile" class="side-nav">

                <li>
                    <a href="#">Link in Sidebar</a>
                </li>

                <li>
                    <a href="#!">Alan <span class="new badge">1</span></a>
                </li>

                <li>

                    <div class="switch">
                        <label>
                            Off
                            <input type="checkbox">
                            <span class="lever"></span>
                            On
                        </label>
                    </div>

                </li>

            </ul>

        </div>

    </nav>
</div>

alanjames1987 commented Feb 15, 2015

The screenshot above is from 45a809a, the most recent commit at the time of me posting this and one commit after #683 got resolved.

Here is the code I used to create it.

<div class="navbar-fixed">
    <nav>

        <div class="nav-wrapper black">

            <i class="mdi-navigation-menu button-collapse" data-activates="nav-mobile"></i>

            <ul class="right">
                <li><a href="#">Navbar Link</a></li>
            </ul>

            <ul id="nav-mobile" class="side-nav">

                <li>
                    <a href="#">Link in Sidebar</a>
                </li>

                <li>
                    <a href="#!">Alan <span class="new badge">1</span></a>
                </li>

                <li>

                    <div class="switch">
                        <label>
                            Off
                            <input type="checkbox">
                            <span class="lever"></span>
                            On
                        </label>
                    </div>

                </li>

            </ul>

        </div>

    </nav>
</div>
@Dogfalo

This comment has been minimized.

Show comment
Hide comment
@Dogfalo

Dogfalo Feb 15, 2015

Owner

I just tested your code, the switch is working as intended

Owner

Dogfalo commented Feb 15, 2015

I just tested your code, the switch is working as intended

@alanjames1987

This comment has been minimized.

Show comment
Hide comment
@alanjames1987

alanjames1987 Feb 15, 2015

I recloned the repo to my project and I was still getting the same thing.

After I ran grunt sass:expanded the switch is fixed, but not the badge.

Just a note, I had to recompile the Sass before the switch worked.

Here is what I get now.

sidebar

alanjames1987 commented Feb 15, 2015

I recloned the repo to my project and I was still getting the same thing.

After I ran grunt sass:expanded the switch is fixed, but not the badge.

Just a note, I had to recompile the Sass before the switch worked.

Here is what I get now.

sidebar

@Dogfalo

This comment has been minimized.

Show comment
Hide comment
@Dogfalo

Dogfalo Feb 15, 2015

Owner

Badges in Collapsible request is already open here: #687

Owner

Dogfalo commented Feb 15, 2015

Badges in Collapsible request is already open here: #687

@Dogfalo Dogfalo closed this Feb 15, 2015

@alanjames1987

This comment has been minimized.

Show comment
Hide comment
@alanjames1987

alanjames1987 commented Feb 15, 2015

This IS issue #687.

@Dogfalo

This comment has been minimized.

Show comment
Hide comment
@Dogfalo

Dogfalo Feb 15, 2015

Owner

I meant #581, sorry.

Owner

Dogfalo commented Feb 15, 2015

I meant #581, sorry.

@alanjames1987

This comment has been minimized.

Show comment
Hide comment
@alanjames1987

alanjames1987 Feb 15, 2015

Cool. I will follow that issue.

Thank you for your quick reply.

alanjames1987 commented Feb 15, 2015

Cool. I will follow that issue.

Thank you for your quick reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment