Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) add missing breakpoint and change the other breakpoints #4462

Closed
wants to merge 2 commits into from
Closed

(WIP) add missing breakpoint and change the other breakpoints #4462

wants to merge 2 commits into from

Conversation

DanielRuf
Copy link
Contributor

@DanielRuf
Copy link
Contributor Author

DanielRuf commented Mar 30, 2017

Well there is a conflict with the official guide and some inconsistent things.

http://materializecss.com/sass.html#media

Small screens are defined as having a max-width of 600px 
Medium screens are defined as having a max-width of 992px 
Large screen are defined as having a min-width of 993px 
Extra Large screen are defined as having a min-width of 1200px

It should be (mobile first)

Extra Small screens are defined as having a max-width of 600px 
Small screens are defined as having a min-width of 601px 
Medium screens are defined as having a min-width of 961px 
Large screens are defined as having a min-width of 1280px
Extra Large screens are defined as having a min-width of 1920px

@DanielRuf DanielRuf changed the title add missing breakpoint and change the other breakpoints (WIP) add missing breakpoint and change the other breakpoints Mar 30, 2017
@tomscholz
Copy link
Contributor

Can you take this or put it in this pr/branch?

@DanielRuf
Copy link
Contributor Author

Done.

@stap123
Copy link

stap123 commented Nov 21, 2017

Is the plan to update the breakpoints to the ones listed above or is this now not happening?

@DanielRuf
Copy link
Contributor Author

What is the current state of this proposed change?

@DanielRuf DanielRuf closed this Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants