fix: Fix script hanging for 30 seconds #414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@garyking These changes make sense, thanks for opening the PR. There are some linting issues that just need to be resolved, please see the CI failure to see what those are. |
scottlovegrove
changed the title
Contributor
Author
|
@scottlovegrove Okay, done. |
scottlovegrove
approved these changes
Nov 26, 2025
scottlovegrove
added a commit
to Doist/twist-sdk-typescript
that referenced
this pull request
Nov 27, 2025
Fixes connection hang issue similar to todoist-api-typescript#406 where processes would hang for ~30 seconds after API calls complete when using Node.js native fetch. ## Root Cause Node.js native fetch uses undici with ~30s keepAlive timeout by default. Additionally, the configured timeout (30s) was never actually applied to fetch calls, and timeout handlers weren't being cleared properly. ## Changes - **Add undici Agent**: Configure HTTP agent with 1ms keepAlive timeout and pass via dispatcher option to prevent connection hangs - **Fix timeout bug**: Actually apply the configured 30s timeout to fetch calls - **Add timeout cleanup**: Implement proper clearTimeout functionality to prevent hanging timeout handlers - **Maintain compatibility**: CustomFetch implementations unaffected, no breaking changes to public API ## Dependencies - Added undici ^7.16.0 for connection management ## Testing - All existing tests pass (166/166) - Connection hang test confirms ~2s execution vs ~31s before fix - Timeout enforcement now works correctly Addresses same issues as: - Doist/todoist-api-typescript#408 - Doist/todoist-api-typescript#414 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
scottlovegrove
added a commit
to Doist/twist-sdk-typescript
that referenced
this pull request
Nov 27, 2025
Fixes connection hang issue similar to todoist-api-typescript#406 where processes would hang for ~30 seconds after API calls complete when using Node.js native fetch. ## Root Cause Node.js native fetch uses undici with ~30s keepAlive timeout by default. Additionally, the configured timeout (30s) was never actually applied to fetch calls, and timeout handlers weren't being cleared properly. ## Changes - **Add undici Agent**: Configure HTTP agent with 1ms keepAlive timeout and pass via dispatcher option to prevent connection hangs - **Fix timeout bug**: Actually apply the configured 30s timeout to fetch calls - **Add timeout cleanup**: Implement proper clearTimeout functionality to prevent hanging timeout handlers - **Maintain compatibility**: CustomFetch implementations unaffected, no breaking changes to public API ## Dependencies - Added undici ^7.16.0 for connection management ## Testing - All existing tests pass (166/166) - Connection hang test confirms ~2s execution vs ~31s before fix - Timeout enforcement now works correctly Addresses same issues as: - Doist/todoist-api-typescript#408 - Doist/todoist-api-typescript#414 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some changes made, using GPT-5, which fixed the issue in #406 for me.
Specifically, it appears to be this line that fixes the issue for me.