From 434bb1bec79d5d1ee8dd62ecc508874ccf443aa1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcos=20Garci=CC=81a=20de=20La=20Fuente?= Date: Sun, 20 Jul 2014 00:10:40 +0200 Subject: [PATCH 1/4] Migrated old message notifications to the """new""" system --- htdocs/adherents/admin/adherent.php | 8 +-- htdocs/adherents/ldap.php | 4 +- htdocs/admin/external_rss.php | 2 - htdocs/admin/menus/edit.php | 27 +++----- htdocs/admin/tools/update.php | 12 ++-- htdocs/comm/mailing/fiche.php | 34 ++++------ htdocs/compta/paiement/fiche.php | 20 ++---- htdocs/compta/sociales/charges.php | 16 ++--- htdocs/contact/ldap.php | 10 +-- .../modules/mailings/xinputfile.modules.php | 2 - htdocs/ecm/index.php | 12 +--- htdocs/ecm/index_auto.php | 13 ++-- htdocs/fourn/paiement/fiche.php | 18 ++--- htdocs/ftp/admin/ftpclient.php | 2 - htdocs/ftp/index.php | 28 +++----- htdocs/holiday/admin/holiday.php | 4 +- htdocs/holiday/define_holiday.php | 5 +- htdocs/imports/import.php | 27 +++----- htdocs/paybox/admin/paybox.php | 4 +- htdocs/product/fournisseurs.php | 26 +++---- htdocs/product/price.php | 17 ++--- htdocs/product/stock/fiche.php | 19 ++---- htdocs/user/fiche.php | 68 +++++++++---------- htdocs/user/group/fiche.php | 32 +++------ htdocs/user/group/ldap.php | 10 +-- htdocs/user/ldap.php | 10 +-- 26 files changed, 156 insertions(+), 274 deletions(-) diff --git a/htdocs/adherents/admin/adherent.php b/htdocs/adherents/admin/adherent.php index 0a251536ff6f7..670260f12876d 100644 --- a/htdocs/adherents/admin/adherent.php +++ b/htdocs/adherents/admin/adherent.php @@ -68,11 +68,11 @@ if (! $error) { - $mesg = '
'.$langs->trans("SetupSaved").'
'; + setEventMessage($langs->trans("SetupSaved")); } else { - $mesg = '
'.$langs->trans("Error").'
'; + setEventMessage($langs->trans("Error"), 'errors'); } } @@ -117,10 +117,6 @@ dol_fiche_head($head, 'general', $langs->trans("Members"), 0, 'user'); - -dol_htmloutput_mesg($mesg); - - print_fiche_titre($langs->trans("MemberMainOptions"),'',''); print ''; print ''; diff --git a/htdocs/adherents/ldap.php b/htdocs/adherents/ldap.php index ca651854a24e5..b02fa90baa9f1 100644 --- a/htdocs/adherents/ldap.php +++ b/htdocs/adherents/ldap.php @@ -75,12 +75,12 @@ if ($result >= 0) { - $message.='
'.$langs->trans("MemberSynchronized").'
'; + setEventMessage($langs->trans("MemberSynchronized")); $db->commit(); } else { - $message.='
'.$ldap->error.'
'; + setEventMessage($ldap->error, 'errors'); $db->rollback(); } } diff --git a/htdocs/admin/external_rss.php b/htdocs/admin/external_rss.php index 1944521a58151..f23e80f78ff7d 100644 --- a/htdocs/admin/external_rss.php +++ b/htdocs/admin/external_rss.php @@ -105,7 +105,6 @@ if ($result1 && $result2) { $db->commit(); - //$mesg='
'.$langs->trans("Success").'
'; header("Location: ".$_SERVER["PHP_SELF"]); exit; } @@ -171,7 +170,6 @@ if ($result1 && $result2) { $db->commit(); - //$mesg='
'.$langs->trans("Success").'
'; header("Location: external_rss.php"); exit; } diff --git a/htdocs/admin/menus/edit.php b/htdocs/admin/menus/edit.php index d99a02308b7ab..42d1ed5c9ca02 100644 --- a/htdocs/admin/menus/edit.php +++ b/htdocs/admin/menus/edit.php @@ -39,7 +39,6 @@ $dirmenu = array($dirstandard,$dirsmartphone); $action=GETPOST('action'); -$mesg=GETPOST('mesg'); $menu_handler_top=$conf->global->MAIN_MENU_STANDARD; $menu_handler_smartphone=$conf->global->MAIN_MENU_SMARTPHONE; @@ -79,16 +78,16 @@ $result=$menu->update($user); if ($result > 0) { - $mesg='
'.$langs->trans("RecordModifiedSuccessfully").'
'; + setEventMessage($langs->trans("RecordModifiedSuccessfully")); } else { - $mesg='
'.$menu->error.'
'; + setEventMessage($menu->error, 'errors'); } } else { - $mesg='
'.$menu->error.'
'; + setEventMessage($menu->error, 'errors'); } $_GET["menuId"] = $_POST['menuId']; $action = "edit"; @@ -136,37 +135,37 @@ $error=0; if (! $error && ! $_POST['menu_handler']) { - $mesg='
'.$langs->trans("ErrorFieldRequired",$langs->transnoentities("MenuHandler")).'
'; + setEventMessage($langs->trans("ErrorFieldRequired",$langs->transnoentities("MenuHandler")), 'errors'); $action = 'create'; $error++; } if (! $error && ! $_POST['type']) { - $mesg='
'.$langs->trans("ErrorFieldRequired",$langs->transnoentities("Type")).'
'; + setEventMessage($langs->trans("ErrorFieldRequired",$langs->transnoentities("Type")), 'errors'); $action = 'create'; $error++; } if (! $error && ! $_POST['url']) { - $mesg='
'.$langs->trans("ErrorFieldRequired",$langs->trans("Url")).'
'; + setEventMessage($langs->trans("ErrorFieldRequired",$langs->trans("Url")), 'errors'); $action = 'create'; $error++; } if (! $error && ! $_POST['titre']) { - $mesg='
'.$langs->trans("ErrorFieldRequired",$langs->trans("Title")).'
'; + setEventMessage($langs->trans("ErrorFieldRequired",$langs->trans("Title")), 'errors'); $action = 'create'; $error++; } if (! $error && $_POST['menuId'] && $_POST['type'] == 'top') { - $mesg='
'.$langs->trans("ErrorTopMenuMustHaveAParentWithId0").'
'; + setEventMessage($langs->trans("ErrorTopMenuMustHaveAParentWithId0"), 'errors'); $action = 'create'; $error++; } if (! $error && empty($_POST['menuId']) && $_POST['type'] == 'left') { - $mesg='
'.$langs->trans("ErrorLeftMenuMustHaveAParentId").'
'; + setEventMessage($langs->trans("ErrorLeftMenuMustHaveAParentId"), 'errors'); $action = 'create'; $error++; } @@ -205,7 +204,7 @@ else { $action = 'create'; - $mesg='
'.$menu->error.'
'; + setEventMessage($menu->error, 'errors'); } } } @@ -223,7 +222,7 @@ $this->db->commit(); llxHeader(); - print '
'.$langs->trans("MenuDeleted").'
'; + setEventMessage($langs->trans("MenuDeleted")); llxFooter(); exit ; } @@ -375,8 +374,6 @@ function init_topleft() print ''; print ''; - - dol_htmloutput_mesg($mesg); } elseif ($action == 'edit') { @@ -463,8 +460,6 @@ function init_topleft() print ''; print '
'; - - dol_htmloutput_mesg($mesg); } diff --git a/htdocs/admin/tools/update.php b/htdocs/admin/tools/update.php index d58e7444e7110..15d5b5f3d5278 100644 --- a/htdocs/admin/tools/update.php +++ b/htdocs/admin/tools/update.php @@ -54,7 +54,7 @@ if (! $original_file) { $langs->load("Error"); - $mesg = '
'.$langs->trans("ErrorFileRequired").'
'; + setEventMessage($langs->trans("ErrorFileRequired"), 'warnings'); $error++; } else @@ -62,7 +62,7 @@ if (! preg_match('/\.zip/i',$original_file)) { $langs->load("errors"); - $mesg = '
'.$langs->trans("ErrorFileMustBeADolibarrPackage",$original_file).'
'; + setEventMessage($langs->trans("ErrorFileMustBeADolibarrPackage",$original_file), 'errors'); $error++; } } @@ -80,12 +80,11 @@ if (! empty($result['error'])) { $langs->load("errors"); - $mesg = '
'.$langs->trans($result['error'],$original_file).'
'; - + setEventMessage($langs->trans($result['error'],$original_file), 'errors'); } else { - $mesg = '
'.$langs->trans("SetupIsReadyForUse").'
'; + setEventMessage($langs->trans("SetupIsReadyForUse")); } } } @@ -107,9 +106,6 @@ print $langs->trans("LastStableVersion").' : '.$langs->trans("FeatureNotYetAvailable").'
'; print '
'; -//dol_htmloutput_errors($mesg); -dol_htmloutput_mesg($mesg); - print $langs->trans("Upgrade").'
'; print '
'; print $langs->trans("ThisIsProcessToFollow").'
'; diff --git a/htdocs/comm/mailing/fiche.php b/htdocs/comm/mailing/fiche.php index 60c587ac67469..7bdc468085392 100644 --- a/htdocs/comm/mailing/fiche.php +++ b/htdocs/comm/mailing/fiche.php @@ -107,7 +107,7 @@ { if (empty($_REQUEST["clone_content"]) && empty($_REQUEST["clone_receivers"])) { - $mesg='
'.$langs->trans("NoCloneOptionsSpecified").'
'; + setEventMessage($langs->trans("NoCloneOptionsSpecified"), 'errors'); } else { @@ -119,7 +119,7 @@ } else { - $mesg=$object->error; + setEventMessage($object->error, 'errors'); } } $action=''; @@ -130,16 +130,17 @@ { if (empty($conf->global->MAILING_LIMIT_SENDBYWEB)) { + //TODO: What is this for? // Pour des raisons de securite, on ne permet pas cette fonction via l'IHM, // on affiche donc juste un message - $mesg='
'.$langs->trans("MailingNeedCommand").'
'; - $mesg.='
'; - $mesg.='

'.$langs->trans("MailingNeedCommand2").'
'; + setEventMessage($langs->trans("MailingNeedCommand"), 'warnings'); + setEventMessage('', 'warnings'); + setEventMessage($langs->trans("MailingNeedCommand2"), 'warnings'); $action=''; } else if ($conf->global->MAILING_LIMIT_SENDBYWEB < 0) { - $mesg='
'.$langs->trans("NotEnoughPermissions").'
'; + setEventMessage($langs->trans("NotEnoughPermissions"), 'warnings'); $action=''; } else @@ -390,7 +391,7 @@ $object->sendto = $_POST["sendto"]; if (! $object->sendto) { - $mesg='
'.$langs->trans("ErrorFieldRequired",$langs->trans("MailTo")).'
'; + setEventMessage($langs->trans("ErrorFieldRequired",$langs->trans("MailTo")), 'errors'); $error++; } @@ -430,11 +431,11 @@ $result=$mailfile->sendfile(); if ($result) { - $mesg='
'.$langs->trans("MailSuccessfulySent",$mailfile->getValidAddress($object->email_from,2),$mailfile->getValidAddress($object->sendto,2)).'
'; + setEventMessage($langs->trans("MailSuccessfulySent",$mailfile->getValidAddress($object->email_from,2),$mailfile->getValidAddress($object->sendto,2))); } else { - $mesg='
'.$langs->trans("ResultKo").'
'.$mailfile->error.' '.$result.'
'; + setEventMessage($langs->trans("ResultKo").'
'.$mailfile->error.' '.$result, 'errors'); } $action=''; @@ -467,7 +468,7 @@ $mesg=$object->error; } - $mesg='
'.$mesg.'
'; + setEventMessage($mesg, 'errors'); $action="create"; } @@ -494,7 +495,7 @@ $mesg=$object->error; } - $mesg='
'.$mesg.'
'; + setEventMessage($mesg, 'errors'); $action=""; } @@ -552,7 +553,7 @@ $mesg=$object->error; } - $mesg='
'.$mesg.'
'; + setEventMessage($mesg, 'errors'); $action="edit"; } else @@ -598,7 +599,7 @@ } else { - $mesg=$object->error; + setEventMessage($object->error, 'errors'); $db->rollback(); } } @@ -646,8 +647,6 @@ print_fiche_titre($langs->trans("NewMailing")); - dol_htmloutput_mesg($mesg); - print '
'; print ''; print ''; @@ -829,9 +828,6 @@ print $form->formconfirm($_SERVER["PHP_SELF"].'?id='.$object->id,$langs->trans('CloneEMailing'),$langs->trans('ConfirmCloneEMailing',$object->ref),'confirm_clone',$formquestion,'yes',2,240); } - - dol_htmloutput_mesg($mesg); - /* * Boutons d'action */ @@ -1017,8 +1013,6 @@ * Mailing en mode edition */ - dol_htmloutput_mesg($mesg); - print '
'.$langs->trans("MailTitle").'
'.$langs->trans("MailFrom").'
'; // Ref diff --git a/htdocs/compta/paiement/fiche.php b/htdocs/compta/paiement/fiche.php index 97f3fb9d47c10..74ec9f4cb692e 100644 --- a/htdocs/compta/paiement/fiche.php +++ b/htdocs/compta/paiement/fiche.php @@ -45,8 +45,6 @@ // TODO ajouter regle pour restreindre acces paiement //$result = restrictedArea($user, 'facture', $id,''); -$mesg=''; - $object = new Paiement($db); @@ -67,7 +65,7 @@ } else { - $mesg='
'.$object->error.'
'; + setEventMessage($object->error, 'errors'); $db->rollback(); } } @@ -87,7 +85,7 @@ else { $langs->load("errors"); - $mesg='
'.$langs->trans($object->error).'
'; + setEventMessage($langs->trans($object->error), 'errors'); $db->rollback(); } } @@ -123,7 +121,7 @@ else { $langs->load("errors"); - $mesg='
'.$langs->trans($object->error).'
'; + setEventMessage($langs->trans($object->error), 'errors'); $db->rollback(); } } @@ -134,11 +132,11 @@ $res = $object->update_num($_POST['num_paiement']); if ($res === 0) { - $mesg = '
'.$langs->trans('PaymentNumberUpdateSucceeded').'
'; + setEventMessage($langs->trans('PaymentNumberUpdateSucceeded')); } else { - $mesg = '
'.$langs->trans('PaymentNumberUpdateFailed').'
'; + setEventMessage($langs->trans('PaymentNumberUpdateFailed'), 'errors'); } } @@ -149,11 +147,11 @@ $res = $object->update_date($datepaye); if ($res === 0) { - $mesg = '
'.$langs->trans('PaymentDateUpdateSucceeded').'
'; + setEventMessage($langs->trans('PaymentDateUpdateSucceeded')); } else { - $mesg = '
'.$langs->trans('PaymentDateUpdateFailed').'
'; + setEventMessage($langs->trans('PaymentDateUpdateFailed'), 'errors'); } } @@ -198,10 +196,6 @@ } - -dol_htmloutput_mesg($mesg); - - print '
'; // Ref diff --git a/htdocs/compta/sociales/charges.php b/htdocs/compta/sociales/charges.php index 48a8f65695936..1583c8ebc498f 100644 --- a/htdocs/compta/sociales/charges.php +++ b/htdocs/compta/sociales/charges.php @@ -110,13 +110,9 @@ $chargesociales->amount=$_POST["amount"]; $id=$chargesociales->create($user); - if ($id > 0) + if ($id <= 0) { - //$mesg='
'.$langs->trans("SocialContributionAdded").'
'; - } - else - { - $mesg='
'.$chargesociales->error.'
'; + setEventMessage($chargesociales->error, 'errors'); } } } @@ -146,13 +142,9 @@ $chargesociales->periode=$dateperiod; $result=$chargesociales->update($user); - if ($result > 0) - { - //$mesg='
'.$langs->trans("SocialContributionAdded").'
'; - } - else + if ($result <= 0) { - $mesg='
'.$chargesociales->error.'
'; + setEventMessage($chargesociales->error, 'errors'); } } } diff --git a/htdocs/contact/ldap.php b/htdocs/contact/ldap.php index 1681324323ab4..fe3098eaa9a26 100644 --- a/htdocs/contact/ldap.php +++ b/htdocs/contact/ldap.php @@ -49,8 +49,6 @@ if ($action == 'dolibarr2ldap') { - $message=""; - $db->begin(); $ldap=new Ldap(); @@ -64,12 +62,12 @@ if ($result >= 0) { - $message.='
'.$langs->trans("ContactSynchronized").'
'; + setEventMessage($langs->trans("ContactSynchronized")); $db->commit(); } else { - $message.='
'.$ldap->error.'
'; + setEventMessage($ldap->error, 'errors'); $db->rollback(); } } @@ -136,10 +134,6 @@ print ''; - -dol_htmloutput_mesg($message); - - /* * Barre d'actions */ diff --git a/htdocs/core/modules/mailings/xinputfile.modules.php b/htdocs/core/modules/mailings/xinputfile.modules.php index 3ed72bd20346b..777621fa43229 100644 --- a/htdocs/core/modules/mailings/xinputfile.modules.php +++ b/htdocs/core/modules/mailings/xinputfile.modules.php @@ -137,8 +137,6 @@ function add_to_target($mailing_id,$filtersarray=array()) { $cpt=0; - //$mesg = '
'.$langs->trans("FileTransferComplete").'
'; - //print_r($_FILES); $file=$upload_dir . "/" . $_FILES['username']['name']; $handle = @fopen($file, "r"); if ($handle) diff --git a/htdocs/ecm/index.php b/htdocs/ecm/index.php index e46011c45babf..8f9bd5573bf78 100644 --- a/htdocs/ecm/index.php +++ b/htdocs/ecm/index.php @@ -110,8 +110,6 @@ $resupload = dol_move_uploaded_file($_FILES['userfile']['tmp_name'], $upload_dir . "/" . dol_unescapefile($_FILES['userfile']['name']),0, 0, $_FILES['userfile']['error']); if (is_numeric($resupload) && $resupload > 0) { - //$mesg = '
'.$langs->trans("FileTransferComplete").'
'; - //print_r($_FILES); $result=$ecmdir->changeNbOfFiles('+'); } else @@ -134,7 +132,7 @@ else { $langs->load("errors"); - $mesg = '
'.$langs->trans("ErrorFailToCreateDir",$upload_dir).'
'; + setEventMessage($langs->trans("ErrorFailToCreateDir",$upload_dir), 'errors'); } } } @@ -156,7 +154,7 @@ } else { - $mesg='
Error '.$langs->trans($ecmdir->error).'
'; + setEventMessage('Error '.$langs->trans($ecmdir->error), 'errors'); $action = "create"; } @@ -198,7 +196,7 @@ if ($action == 'confirm_deletesection' && GETPOST('confirm') == 'yes') { $result=$ecmdir->delete($user); - $mesg = '
'.$langs->trans("ECMSectionWasRemoved", $ecmdir->label).'
'; + setEventMessage($langs->trans("ECMSectionWasRemoved", $ecmdir->label)); clearstatcache(); } @@ -324,7 +322,6 @@ $dirtotest=$conf->ecm->dir_output.'/'.$dirdesc['fullrelativename']; if (! dol_is_dir($dirtotest)) { - $mesg.=$dirtotest." not found onto disk. We delete from database dir with id=".$dirdesc['id']."
\n"; $ecmdirtmp->id=$dirdesc['id']; $ecmdirtmp->delete($user,'databaseonly'); //exit; @@ -440,9 +437,6 @@ } -dol_htmloutput_mesg($mesg); - - if (! empty($conf->use_javascript_ajax)) $classviewhide='hidden'; else $classviewhide='visible'; diff --git a/htdocs/ecm/index_auto.php b/htdocs/ecm/index_auto.php index 9c4ab7e0e2f46..3e6e6cfa05b45 100644 --- a/htdocs/ecm/index_auto.php +++ b/htdocs/ecm/index_auto.php @@ -110,8 +110,6 @@ $resupload = dol_move_uploaded_file($_FILES['userfile']['tmp_name'], $upload_dir . "/" . dol_unescapefile($_FILES['userfile']['name']),0, 0, $_FILES['userfile']['error']); if (is_numeric($resupload) && $resupload > 0) { - //$mesg = '
'.$langs->trans("FileTransferComplete").'
'; - //print_r($_FILES); $result=$ecmdir->changeNbOfFiles('+'); } else @@ -134,7 +132,7 @@ else { $langs->load("errors"); - $mesg = '
'.$langs->trans("ErrorFailToCreateDir",$upload_dir).'
'; + setEventMessage($langs->trans("ErrorFailToCreateDir",$upload_dir), 'errors'); } } } @@ -156,7 +154,8 @@ } else { - $mesg='
Error '.$langs->trans($ecmdir->error).'
'; + //TODO: Translate + setEventMessage('Error '.$langs->trans($ecmdir->error), 'errors'); $action = "create"; } @@ -198,7 +197,7 @@ if ($action == 'confirm_deletesection' && GETPOST('confirm') == 'yes') { $result=$ecmdir->delete($user); - $mesg = '
'.$langs->trans("ECMSectionWasRemoved", $ecmdir->label).'
'; + setEventMessage($langs->trans("ECMSectionWasRemoved", $ecmdir->label)); clearstatcache(); } @@ -324,7 +323,6 @@ $dirtotest=$conf->ecm->dir_output.'/'.$dirdesc['fullrelativename']; if (! dol_is_dir($dirtotest)) { - $mesg.=$dirtotest." not found onto disk. We delete from database dir with id=".$dirdesc['id']."
\n"; $ecmdirtmp->id=$dirdesc['id']; $ecmdirtmp->delete($user,'databaseonly'); //exit; @@ -436,9 +434,6 @@ } -dol_htmloutput_mesg($mesg); - - if (! empty($conf->use_javascript_ajax)) $classviewhide='hidden'; else $classviewhide='visible'; diff --git a/htdocs/fourn/paiement/fiche.php b/htdocs/fourn/paiement/fiche.php index 9a38e16f7f4dd..32edf72a2ad6d 100644 --- a/htdocs/fourn/paiement/fiche.php +++ b/htdocs/fourn/paiement/fiche.php @@ -36,8 +36,6 @@ $langs->load('companies'); $langs->load("suppliers"); -$mesg=''; - $id = GETPOST('id','int'); $action = GETPOST('action','alpha'); $confirm = GETPOST('confirm','alpha'); @@ -61,7 +59,7 @@ } else { - $mesg='
'.$object->error.'
'; + setEventMessage($object->error, 'errors'); $db->rollback(); } } @@ -80,7 +78,7 @@ } else { - $mesg='
'.$object->error.'
'; + setEventMessage($object->error, 'errors'); $db->rollback(); } } @@ -98,7 +96,7 @@ } else { - $mesg='
'.$object->error.'
'; + setEventMessage($object->error, 'errors'); $db->rollback(); } } @@ -109,11 +107,11 @@ $res = $object->update_num($_POST['num_paiement']); if ($res === 0) { - $mesg = '
'.$langs->trans('PaymentNumberUpdateSucceeded').'
'; + $setEventMessage($langs->trans('PaymentNumberUpdateSucceeded')); } else { - $mesg = '
'.$langs->trans('PaymentNumberUpdateFailed').'
'; + setEventMessage($langs->trans('PaymentNumberUpdateFailed'), 'errors'); } } @@ -124,11 +122,11 @@ $res = $object->update_date($datepaye); if ($res === 0) { - $mesg = '
'.$langs->trans('PaymentDateUpdateSucceeded').'
'; + setEventMessage($langs->trans('PaymentDateUpdateSucceeded')); } else { - $mesg = '
'.$langs->trans('PaymentDateUpdateFailed').'
'; + setEventMessage($langs->trans('PaymentDateUpdateFailed'), 'errors'); } } @@ -229,8 +227,6 @@ print '
'; - dol_htmloutput_mesg($mesg); - print '
'; /** diff --git a/htdocs/ftp/admin/ftpclient.php b/htdocs/ftp/admin/ftpclient.php index 3e9d2bfd59033..a7a98dcc734af 100644 --- a/htdocs/ftp/admin/ftpclient.php +++ b/htdocs/ftp/admin/ftpclient.php @@ -91,7 +91,6 @@ if ($result1 && $result2 && $result3 && $result4 && $result5 && $result6) { $db->commit(); - //$mesg='
'.$langs->trans("Success").'
'; header("Location: ".$_SERVER["PHP_SELF"]); exit; } @@ -119,7 +118,6 @@ if ($result1 && $result2 && $result3 && $result4 && $result5 && $result6) { $db->commit(); - //$mesg='
'.$langs->trans("Success").'
'; header("Location: ".$_SERVER["PHP_SELF"]); exit; } diff --git a/htdocs/ftp/index.php b/htdocs/ftp/index.php index 0c72bcc1b1a22..f1a051bcf2a4f 100644 --- a/htdocs/ftp/index.php +++ b/htdocs/ftp/index.php @@ -100,8 +100,6 @@ $resupload = dol_move_uploaded_file($_FILES['userfile']['tmp_name'], $upload_dir . "/" . dol_unescapefile($_FILES['userfile']['name']),0); if (is_numeric($resupload) && $resupload > 0) { - //$mesg = '
'.$langs->trans("FileTransferComplete").'
'; - //print_r($_FILES); $result=$ecmdir->changeNbOfFiles('+'); } else { @@ -124,7 +122,7 @@ { // Echec transfert (fichier depassant la limite ?) $langs->load("errors"); - $mesg = '
'.$langs->trans("ErrorFailToCreateDir",$upload_dir).'
'; + setEventMessage($langs->trans("ErrorFailToCreateDir",$upload_dir), 'errors'); } } @@ -143,7 +141,8 @@ } else { - $mesg='
Error '.$langs->trans($ecmdir->error).'
'; + //TODO: Translate + setEventMessage('Error '.$langs->trans($ecmdir->error)); $_GET["action"] = "create"; } } @@ -175,12 +174,12 @@ $result=@ftp_delete($conn_id, $newremotefileiso); if ($result) { - $mesg = '
'.$langs->trans("FileWasRemoved",$file).'
'; + setEventMessage($langs->trans("FileWasRemoved",$file)); } else { dol_syslog("ftp/index.php ftp_delete", LOG_ERR); - $mesg = '
'.$langs->trans("FTPFailedToRemoveFile",$file).'
'; + setEventMessage($langs->trans("FTPFailedToRemoveFile",$file), 'errors'); } //ftp_close($conn_id); Close later @@ -225,12 +224,12 @@ $result=@ftp_delete($conn_id, $newremotefileiso); if ($result) { - $mesg .= '
'.$langs->trans("FileWasRemoved",$file).'
'; + setEventMessage($langs->trans("FileWasRemoved",$file)); } else { dol_syslog("ftp/index.php ftp_delete", LOG_ERR); - $mesg .= '
'.$langs->trans("FTPFailedToRemoveFile",$file).'
'; + setEventMessage($langs->trans("FTPFailedToRemoveFile",$file), 'errors'); } //ftp_close($conn_id); Close later @@ -269,11 +268,11 @@ $result=@ftp_rmdir($conn_id, $newremotefileiso); if ($result) { - $mesg = '
'.$langs->trans("DirWasRemoved",$file).'
'; + setEventMessage($langs->trans("DirWasRemoved",$file)); } else { - $mesg = '
'.$langs->trans("FTPFailedToRemoveDir",$file).'
'; + setEventMessage($langs->trans("FTPFailedToRemoveDir",$file), 'errors'); } //ftp_close($conn_id); Close later @@ -340,7 +339,8 @@ } else { - $mesg='
Failed to get file '.$remotefile.'
'; + //TODO: Translate + setEventMessage('Failed to get file '.$remotefile, 'errors'); } } @@ -444,9 +444,6 @@ print '
'; print "
\n"; - if ($mesg) { print $mesg."
"; } - - print '
'; print ''; print ''; @@ -596,9 +593,6 @@ print ""; - - if (! $ok && $mesg) print $mesg; - // Actions /* if ($user->rights->ftp->write && ! empty($section)) diff --git a/htdocs/holiday/admin/holiday.php b/htdocs/holiday/admin/holiday.php index 2b265711fa134..aabf8362c0553 100644 --- a/htdocs/holiday/admin/holiday.php +++ b/htdocs/holiday/admin/holiday.php @@ -142,9 +142,9 @@ if ($error) { - $message = '
'.$langs->trans('ErrorUpdateConfCP').'
'; + setEventMessage($langs->trans('ErrorUpdateConfCP'), 'errors'); } else { - $message = '
'.$langs->trans('UpdateConfCPOK').'
'; + setEventMessage($langs->trans('UpdateConfCPOK')); } // Si première mise à jour, prévenir l'utilisateur de mettre à jour le solde des congés payés diff --git a/htdocs/holiday/define_holiday.php b/htdocs/holiday/define_holiday.php index 0ac67b6657915..bf1bf046783ef 100644 --- a/htdocs/holiday/define_holiday.php +++ b/htdocs/holiday/define_holiday.php @@ -84,10 +84,7 @@ dol_syslog('define_holiday update lastUpdate entry', LOG_DEBUG); $result = $db->query($sql); - $mesg='
'.$langs->trans('UpdateConfCPOK').'
'; - - dol_htmloutput_mesg($mesg); - + setEventMessage($langs->trans('UpdateConfCPOK')); } elseif($action == 'add_event') { diff --git a/htdocs/imports/import.php b/htdocs/imports/import.php index 41a82de36b1be..0b4856fab61f1 100644 --- a/htdocs/imports/import.php +++ b/htdocs/imports/import.php @@ -138,11 +138,11 @@ $result=$objimport->build_file($user, GETPOST('model','alpha'), $datatoimport, $array_match_file_to_database); if ($result < 0) { - $mesg='
'.$objimport->error.'
'; + setEventMessage($objimport->error, 'errors'); } else { - $mesg='
'.$langs->trans("FileSuccessfullyBuilt").'
'; + setEventMessage($langs->trans("FileSuccessfullyBuilt")); } } @@ -175,21 +175,23 @@ $result = $objimport->create($user); if ($result >= 0) { - $mesg='
'.$langs->trans("ImportModelSaved",$objimport->model_name).'
'; + setEventMessage($langs->trans("ImportModelSaved",$objimport->model_name)); } else { $langs->load("errors"); if ($objimport->errno == 'DB_ERROR_RECORD_ALREADY_EXISTS') { - $mesg='
'.$langs->trans("ErrorImportDuplicateProfil").'
'; + setEventMessage($langs->trans("ErrorImportDuplicateProfil"), 'errors'); + } + else { + setEventMessage($objimport->error, 'errors'); } - else $mesg='
'.$objimport->error.'
'; } } else { - $mesg='
'.$langs->trans("ErrorFieldRequired",$langs->transnoentities("ImportModelName")).'
'; + setEventMessage($langs->trans("ErrorFieldRequired",$langs->transnoentities("ImportModelName")), 'errors'); } } @@ -385,8 +387,6 @@ dol_fiche_end(); - if ($mesg) print $mesg; - } @@ -461,7 +461,6 @@ dol_fiche_end(); - if ($mesg) print $mesg; } @@ -597,10 +596,7 @@ print '
'; - dol_fiche_end(); - - if ($mesg) print $mesg; } @@ -1010,9 +1006,6 @@ print ''."\n"; } - - if ($mesg) print $mesg; - /* * Barre d'action */ @@ -1438,8 +1431,6 @@ } print ''; } - - if ($mesg) print $mesg; } @@ -1679,8 +1670,6 @@ print $langs->trans("FileWasImported",$importid).'
'; print $langs->trans("YouCanUseImportIdToFindRecord",$importid).'
'; print ''; - - if ($mesg) print $mesg; } diff --git a/htdocs/paybox/admin/paybox.php b/htdocs/paybox/admin/paybox.php index 7eefafb9c8c00..30e0259119021 100644 --- a/htdocs/paybox/admin/paybox.php +++ b/htdocs/paybox/admin/paybox.php @@ -67,7 +67,7 @@ if (! $error) { $db->commit(); - $mesg='
'.$langs->trans("SetupSaved").'
'; + setEventMessage($langs->trans("SetupSaved")); } else { @@ -227,8 +227,6 @@ print "
"; print info_admin($langs->trans("YouCanAddTagOnUrl")); -dol_htmloutput_mesg($mesg); - $db->close(); dol_fiche_end(); llxFooter(); diff --git a/htdocs/product/fournisseurs.php b/htdocs/product/fournisseurs.php index 527615cc7c45c..037bb2b1f8b92 100644 --- a/htdocs/product/fournisseurs.php +++ b/htdocs/product/fournisseurs.php @@ -43,7 +43,7 @@ $action=GETPOST('action', 'alpha'); $socid=GETPOST('socid', 'int'); $backtopage=GETPOST('backtopage','alpha'); -$error=0; $mesg = ''; +$error=0; // If socid provided by ajax company selector if (! empty($_REQUEST['search_fourn_id'])) @@ -92,7 +92,7 @@ { $result=$product->remove_product_fournisseur_price($rowid); $action = ''; - $mesg = '
'.$langs->trans("PriceRemoved").'.
'; + setEventMessage($langs->trans("PriceRemoved")); } } } @@ -112,27 +112,27 @@ if ($tva_tx == '') { $error++; - $mesg='
'.$langs->trans("ErrorFieldRequired",$langs->transnoentities("VATRateForSupplierProduct")).'
'; + setEventMessage($langs->trans("ErrorFieldRequired",$langs->transnoentities("VATRateForSupplierProduct")), 'errors'); } if (empty($quantity)) { $error++; - $mesg='
'.$langs->trans("ErrorFieldRequired",$langs->transnoentities("Qty")).'
'; + setEventMessage($langs->trans("ErrorFieldRequired",$langs->transnoentities("Qty")), 'errors'); } if (empty($ref_fourn)) { $error++; - $mesg='
'.$langs->trans("ErrorFieldRequired",$langs->transnoentities("RefSupplier")).'
'; + setEventMessage($langs->trans("ErrorFieldRequired",$langs->transnoentities("RefSupplier")), 'errors'); } if ($id_fourn <= 0) { $error++; - $mesg='
'.$langs->trans("ErrorFieldRequired",$langs->transnoentities("Supplier")).'
'; + setEventMessage($langs->trans("ErrorFieldRequired",$langs->transnoentities("Supplier")), 'errors'); } if ($_POST["price"] < 0 || $_POST["price"] == '') { $error++; - $mesg='
'.$langs->trans("ErrorFieldRequired",$langs->transnoentities("Price")).'
'; + setEventMessage($langs->trans("ErrorFieldRequired",$langs->transnoentities("Price")), 'errors'); } $product = new ProductFournisseur($db); @@ -140,7 +140,7 @@ if ($result <= 0) { $error++; - $mesg=$product->error; + setEventMessage($product->error, 'errors'); } if (! $error) @@ -157,12 +157,12 @@ $product->fetch($product->product_id_already_linked); $productLink = $product->getNomUrl(1,'supplier'); - $mesg='
'.$langs->trans("ReferenceSupplierIsAlreadyAssociatedWithAProduct",$productLink).'
'; + setEventMessage($langs->trans("ReferenceSupplierIsAlreadyAssociatedWithAProduct",$productLink), 'errors'); } else if ($ret < 0) { $error++; - $mesg='
'.$product->error.'
'; + setEventMessage($product->error, 'errors'); } } @@ -177,7 +177,7 @@ if ($ret < 0) { $error++; - $mesg='
'.$product->error.'
'; + setEventMessage($product->error, 'errors'); } } @@ -264,10 +264,6 @@ print "\n"; - - dol_htmloutput_mesg($mesg); - - // Form to add or update a price if (($action == 'add_price' || $action == 'updateprice' ) && ($user->rights->produit->creer || $user->rights->service->creer)) { diff --git a/htdocs/product/price.php b/htdocs/product/price.php index f5db524ed274e..9c0597ec0f607 100644 --- a/htdocs/product/price.php +++ b/htdocs/product/price.php @@ -94,15 +94,16 @@ if ($object->updatePrice($newprice, $newpricebase, $user, $newvat, $newprice_min, $level, $newnpr, $newpsq) > 0) { $action = ''; - $mesg = '
' . $langs->trans("RecordSaved") . '
'; + setEventMessage($langs->trans("RecordSaved")); } else { $action = 'edit_price'; - $mesg = '
' . $object->error . '
'; + setEventMessage($object->error, 'errors'); } } else if ($action == 'delete' && $user->rights->produit->supprimer) { $result = $object->log_price_delete($user, $_GET ["lineid"]); - if ($result < 0) - $mesg = '
' . $object->error . '
'; + if ($result < 0) { + setEventMessage($object->error, 'errors'); + } } /** @@ -136,11 +137,11 @@ if (empty($quantity)) { $error ++; - $mesg = '
' . $langs->trans("ErrorFieldRequired", $langs->transnoentities("Qty")) . '
'; + setEventMessage($langs->trans("ErrorFieldRequired", $langs->transnoentities("Qty")), 'errors'); } if (empty($newprice)) { $error ++; - $mesg = '
' . $langs->trans("ErrorFieldRequired", $langs->transnoentities("Price")) . '
'; + setEventMessage($langs->trans("ErrorFieldRequired", $langs->transnoentities("Price")), 'errors'); } if (! $error) { // Calcul du prix HT et du prix unitaire @@ -547,10 +548,6 @@ print "\n"; -if (! empty($mesg)) { - dol_htmloutput_mesg($mesg); -} - /* ************************************************************************** */ /* */ /* Barre d'action */ diff --git a/htdocs/product/stock/fiche.php b/htdocs/product/stock/fiche.php index 874b082ceae8c..86e930d8cf16d 100644 --- a/htdocs/product/stock/fiche.php +++ b/htdocs/product/stock/fiche.php @@ -43,8 +43,6 @@ if (! $sortfield) $sortfield="p.ref"; if (! $sortorder) $sortorder="DESC"; -$mesg = ''; - // Security check $result=restrictedArea($user,'stock'); @@ -80,10 +78,10 @@ } $action = 'create'; - $mesg='
'.$object->error.'
'; + setEventMessage($object->error, 'errors'); } else { - $mesg='
'.$langs->trans("ErrorWarehouseRefRequired").'
'; + setEventMessage($langs->trans("ErrorWarehouseRefRequired"), 'errors'); $action="create"; // Force retour sur page creation } } @@ -101,7 +99,7 @@ } else { - $mesg='
'.$object->error.'
'; + setEventMessage($object->error, 'errors'); $action=''; } } @@ -124,18 +122,17 @@ if ( $object->update($id, $user) > 0) { $action = ''; - //$mesg = '
Fiche mise a jour
'; } else { $action = 'edit'; - $mesg = '
'.$object->error.'
'; + setEventMessage($object->error, 'errors'); } } else { $action = 'edit'; - $mesg = '
'.$object->error.'
'; + setEventMessage($object->error, 'errors'); } } @@ -167,8 +164,6 @@ print ''; print ''."\n"; - dol_htmloutput_mesg($mesg); - print ''; // Ref @@ -219,8 +214,6 @@ $id=GETPOST("id",'int'); if ($id) { - dol_htmloutput_mesg($mesg); - $object = new Entrepot($db); $result = $object->fetch($id); if ($result < 0) @@ -496,7 +489,7 @@ */ if (($action == 'edit' || $action == 're-edit') && 1) { - print_fiche_titre($langs->trans("WarehouseEdit"), $mesg); + $langs->trans("WarehouseEdit"); print ''; print ''; diff --git a/htdocs/user/fiche.php b/htdocs/user/fiche.php index 3a5827904f25c..5251f6bc7501e 100644 --- a/htdocs/user/fiche.php +++ b/htdocs/user/fiche.php @@ -45,7 +45,6 @@ $confirm = GETPOST('confirm','alpha'); $subaction = GETPOST('subaction','alpha'); $group = GETPOST("group","int",3); -$message=''; // Define value to know what current user can do on users $canadduser=(! empty($user->admin) || $user->rights->user->user->creer); @@ -110,6 +109,8 @@ } if ($action == 'confirm_enable' && $confirm == "yes" && $candisableuser) { + $error = 0; + if ($id <> $user->id) { $object->fetch($id); @@ -119,11 +120,12 @@ $nb = $object->getNbOfUsers("active"); if ($nb >= $conf->file->main_limit_users) { - $message='
'.$langs->trans("YourQuotaOfUsersIsReached").'
'; + $error++; + setEventMessage($langs->trans("YourQuotaOfUsersIsReached"), 'errors'); } } - if (! $message) + if (! $error) { $object->setstatus(1); header("Location: ".$_SERVER['PHP_SELF'].'?id='.$id); @@ -142,7 +144,7 @@ if ($result < 0) { $langs->load("errors"); - $message='
'.$langs->trans("ErrorUserCannotBeDelete").'
'; + setEventMessage($langs->trans("ErrorUserCannotBeDelete"), 'errors'); } else { @@ -155,14 +157,18 @@ // Action ajout user if ($action == 'add' && $canadduser) { + $error = 0; + if (! $_POST["lastname"]) { - $message='
'.$langs->trans("NameNotDefined").'
'; + $error++; + setEventMessage($langs->trans("NameNotDefined"), 'errors'); $action="create"; // Go back to create page } if (! $_POST["login"]) { - $message='
'.$langs->trans("LoginNotDefined").'
'; + $error++; + setEventMessage($langs->trans("LoginNotDefined"), 'errors'); $action="create"; // Go back to create page } @@ -171,13 +177,13 @@ $nb = $object->getNbOfUsers("active"); if ($nb >= $conf->file->main_limit_users) { - $message='
'.$langs->trans("YourQuotaOfUsersIsReached").'
'; + $error++; + setEventMessage($langs->trans("YourQuotaOfUsersIsReached"), 'errors'); $action="create"; // Go back to create page } } - if (! $message) - { + if (!$error) { $object->lastname = GETPOST("lastname",'alpha'); $object->firstname = GETPOST("firstname",'alpha'); $object->login = GETPOST("login",'alpha'); @@ -266,7 +272,7 @@ } else { - $message.=$object->error; + setEventMessage($object->error, 'errors'); } } } @@ -281,13 +287,13 @@ if (! $_POST["lastname"]) { - $message='
'.$langs->trans("NameNotDefined").'
'; + setEventMessage($langs->trans("NameNotDefined"), 'errors'); $action="edit"; // Go back to create page $error++; } if (! $_POST["login"]) { - $message='
'.$langs->trans("LoginNotDefined").'
'; + setEventMessage($langs->trans("LoginNotDefined"), 'errors'); $action="edit"; // Go back to create page $error++; } @@ -304,7 +310,7 @@ $result=$tmpuser->fetch(0, GETPOST("login")); if ($result > 0) { - $message='
'.$langs->trans("ErrorLoginAlreadyExists").'
'; + setEventMessage($langs->trans("ErrorLoginAlreadyExists"), 'errors'); $action="edit"; // Go back to create page $error++; } @@ -367,11 +373,11 @@ if ($db->errno() == 'DB_ERROR_RECORD_ALREADY_EXISTS') { $langs->load("errors"); - $message.='
'.$langs->trans("ErrorLoginAlreadyExists",$object->login).'
'; + setEventMessage($langs->trans("ErrorLoginAlreadyExists",$object->login), 'errors'); } else { - $message.='
'.$object->error.'
'; + setEventMessage($object->error, 'errors'); } } @@ -395,12 +401,12 @@ $sql.= " SET fk_socpeople=NULL, fk_societe=NULL"; $sql.= " WHERE rowid=".$object->id; } + dol_syslog("fiche::update", LOG_DEBUG); $resql=$db->query($sql); - dol_syslog("fiche::update", LOG_DEBUG); if (! $resql) { $error++; - $message.='
'.$db->lasterror().'
'; + setEventMessage($db->lasterror(), 'errors'); } } @@ -427,7 +433,7 @@ if (! $result > 0) { - $message .= '
'.$langs->trans("ErrorFailedToSaveFile").'
'; + setEventMessage($langs->trans("ErrorFailedToSaveFile"), 'errors'); } else { @@ -445,7 +451,7 @@ if (! $error && ! count($object->errors)) { - $message.='
'.$langs->trans("UserModified").'
'; + setEventMessage($langs->trans("UserModified")); $db->commit(); $login=$_SESSION["dol_login"]; @@ -469,7 +475,7 @@ $ret=$object->setPassword($user,$_POST["password"]); if ($ret < 0) { - $message.='
'.$object->error.'
'; + setEventMessage($object->error, 'errors'); } } } @@ -484,7 +490,7 @@ if ($newpassword < 0) { // Echec - $message = '
'.$langs->trans("ErrorFailedToSetNewPassword").'
'; + setEventMessage($langs->trans("ErrorFailedToSetNewPassword"), 'errors'); } else { @@ -493,18 +499,16 @@ { if ($object->send_password($user,$newpassword) > 0) { - $message = '
'.$langs->trans("PasswordChangedAndSentTo",$object->email).'
'; - //$message.=$newpassword; + setEventMessage($langs->trans("PasswordChangedAndSentTo",$object->email)); } else { - $message = '
'.$langs->trans("PasswordChangedTo",$newpassword).'
'; - $message.= '
'.$object->error.'
'; + setEventMessage($object->error, 'errors'); } } else { - $message = '
'.$langs->trans("PasswordChangedTo",$newpassword).'
'; + setEventMessage($langs->trans("PasswordChangedTo",$newpassword), 'errors'); } } } @@ -562,7 +566,7 @@ } else { - $message='
'.$ldap->error.'
'; + setEventMessage($ldap->error, 'errors'); } } @@ -590,8 +594,6 @@ print "
"; print "
"; - dol_htmloutput_mesg($message); - if (! empty($conf->ldap->enabled) && (isset($conf->global->LDAP_SYNCHRO_ACTIVE) && $conf->global->LDAP_SYNCHRO_ACTIVE == 'ldap2dolibarr')) { /* @@ -648,12 +650,12 @@ } else { - $message='
'.$ldap->error.'
'; + setEventMessage($ldap->error, 'errors'); } } else { - $message='
'.$ldap->error.'
'; + setEventMessage($ldap->error, 'errors'); } // Si la liste des users est rempli, on affiche la liste deroulante @@ -977,7 +979,7 @@ $entries = $ldap->fetch($object->login,$userSearchFilter); if (! $entries) { - $message .= $ldap->error; + setEventMessage($ldap->error, 'errors'); } $passDoNotExpire = 0; @@ -1056,8 +1058,6 @@ print $form->formconfirm("fiche.php?id=$object->id",$langs->trans("DeleteAUser"),$langs->trans("ConfirmDeleteUser",$object->login),"confirm_delete", '', 0, 1); } - dol_htmloutput_mesg($message); - /* * Fiche en mode visu */ diff --git a/htdocs/user/group/fiche.php b/htdocs/user/group/fiche.php index 625195bfa6843..f97ef35ae6eef 100644 --- a/htdocs/user/group/fiche.php +++ b/htdocs/user/group/fiche.php @@ -48,7 +48,6 @@ $action=GETPOST('action', 'alpha'); $confirm=GETPOST('confirm', 'alpha'); $userid=GETPOST('user', 'int'); -$message=''; // Security check $result = restrictedArea($user, 'user', $id, 'usergroup&usergroup', 'user'); @@ -76,7 +75,7 @@ else { $langs->load("errors"); - $message = '
'.$langs->trans('ErrorForbidden').'
'; + setEventMessage($langs->trans('ErrorForbidden'), 'errors'); } } @@ -87,14 +86,10 @@ { if ($caneditperms) { - if (! $_POST["nom"]) - { - $message='
'.$langs->trans("NameNotDefined").'
'; + if (! $_POST["nom"]) { + setEventMessage($langs->trans("NameNotDefined"), 'errors'); $action="create"; // Go back to create page - } - - if (! $message) - { + } else { $object->nom = trim($_POST["nom"]); $object->note = trim($_POST["note"]); @@ -117,7 +112,7 @@ $db->rollback(); $langs->load("errors"); - $message='
'.$langs->trans("ErrorGroupAlreadyExists",$object->nom).'
'; + setEventMessage($langs->trans("ErrorGroupAlreadyExists",$object->nom), 'errors'); $action="create"; // Go back to create page } } @@ -125,7 +120,7 @@ else { $langs->load("errors"); - $message = '
'.$langs->trans('ErrorForbidden').'
'; + setEventMessage($langs->trans('ErrorForbidden'), 'errors'); } } @@ -151,14 +146,14 @@ } else { - $message.=$edituser->error; + setEventMessage($edituser->error, 'errors'); } } } else { $langs->load("errors"); - $message = '
'.$langs->trans('ErrorForbidden').'
'; + setEventMessage($langs->trans('ErrorForbidden'), 'errors'); } } @@ -183,19 +178,19 @@ if ($ret >= 0 && ! count($object->errors)) { - $message.='
'.$langs->trans("GroupModified").'
'; + setEventMessage($langs->trans("GroupModified")); $db->commit(); } else { - $message.='
'.$object->error.'
'; + setEventMessage($object->error); $db->rollback(); } } else { $langs->load("errors"); - $message = '
'.$langs->trans('ErrorForbidden').'
'; + setEventMessage($langs->trans('ErrorForbidden')); } } @@ -214,8 +209,6 @@ { print_fiche_titre($langs->trans("NewGroup")); - if ($message) { print $message."
"; } - print dol_set_focus('#nom'); print ''; @@ -340,9 +333,6 @@ print "\n"; print "
\n"; - - dol_htmloutput_mesg($message); - /* * Liste des utilisateurs dans le groupe */ diff --git a/htdocs/user/group/ldap.php b/htdocs/user/group/ldap.php index cde5e764af562..c3e147620c238 100644 --- a/htdocs/user/group/ldap.php +++ b/htdocs/user/group/ldap.php @@ -56,8 +56,6 @@ if ($action == 'dolibarr2ldap') { - $message=""; - $db->begin(); $ldap=new Ldap(); @@ -71,12 +69,12 @@ if ($result >= 0) { - $message.='
'.$langs->trans("GroupSynchronized").'
'; + setEventMessage($langs->trans("GroupSynchronized")); $db->commit(); } else { - $message.='
'.$ldap->error.'
'; + setEventMessage($ldap->error); $db->rollback(); } } @@ -135,10 +133,6 @@ print ''; - -dol_htmloutput_mesg($message); - - /* * Barre d'actions */ diff --git a/htdocs/user/ldap.php b/htdocs/user/ldap.php index ebf776e64aaa1..87a0dec31e2e5 100644 --- a/htdocs/user/ldap.php +++ b/htdocs/user/ldap.php @@ -52,8 +52,6 @@ if ($_GET["action"] == 'dolibarr2ldap') { - $message=""; - $db->begin(); $ldap=new Ldap(); @@ -67,12 +65,12 @@ if ($result >= 0) { - $message.='
'.$langs->trans("UserSynchronized").'
'; + setEventMessage($langs->trans("UserSynchronized")); $db->commit(); } else { - $message.='
'.$ldap->error.'
'; + setEventMessage($ldap->error, 'errors'); $db->rollback(); } } @@ -152,10 +150,6 @@ print ''; - -dol_htmloutput_mesg($message); - - /* * Barre d'actions */ From ac824728bc8e172d062c7afacb838e190a4a4d27 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcos=20Garci=CC=81a=20de=20La=20Fuente?= Date: Sun, 20 Jul 2014 01:09:43 +0200 Subject: [PATCH 2/4] Migrated old error notifications to the """new""" system --- htdocs/adherents/card_subscriptions.php | 4 +- htdocs/adherents/fiche.php | 95 +++++++++++++------------ htdocs/adherents/fiche_subscription.php | 2 - htdocs/adherents/type.php | 2 - htdocs/admin/fiscalyear_card.php | 16 ++--- htdocs/admin/ldap_users.php | 2 +- htdocs/admin/limits.php | 8 +-- htdocs/admin/mails.php | 10 ++- htdocs/admin/menus/index.php | 2 +- htdocs/admin/system/index.php | 9 ++- htdocs/admin/tools/update.php | 6 +- htdocs/bookmarks/fiche.php | 26 ++++--- htdocs/bookmarks/liste.php | 4 +- htdocs/categories/traduction.php | 8 +-- htdocs/categories/viewcat.php | 5 +- htdocs/comm/action/fiche.php | 17 ++--- htdocs/comm/remx.php | 16 ++--- htdocs/commande/contact.php | 5 +- htdocs/commande/fiche.php | 50 ++++++------- htdocs/commande/orderstoinvoice.php | 22 +++--- htdocs/compta/bank/annuel.php | 2 +- htdocs/compta/bank/bankid_fr.php | 4 +- htdocs/compta/bank/fiche.php | 6 +- htdocs/compta/bank/graph.php | 5 +- htdocs/compta/bank/ligne.php | 10 ++- htdocs/compta/bank/rappro.php | 6 +- htdocs/compta/bank/treso.php | 8 --- htdocs/compta/facture.php | 50 +++++++------ 28 files changed, 178 insertions(+), 222 deletions(-) diff --git a/htdocs/adherents/card_subscriptions.php b/htdocs/adherents/card_subscriptions.php index e436fd5f694e4..fa7d59f040e64 100644 --- a/htdocs/adherents/card_subscriptions.php +++ b/htdocs/adherents/card_subscriptions.php @@ -129,7 +129,7 @@ if ($_POST["userid"] != $user->id && $_POST["userid"] != $object->user_id) { $error++; - $mesg='
'.$langs->trans("ErrorUserPermissionAllowsToLinksToItselfOnly").'
'; + setEventMessage($langs->trans("ErrorUserPermissionAllowsToLinksToItselfOnly"), 'errors'); } } @@ -165,7 +165,7 @@ $thirdparty=new Societe($db); $thirdparty->fetch(GETPOST('socid','int')); $error++; - $mesg='
'.$langs->trans("ErrorMemberIsAlreadyLinkedToThisThirdParty",$othermember->getFullName($langs),$othermember->login,$thirdparty->name).'
'; + setEventMessage($langs->trans("ErrorMemberIsAlreadyLinkedToThisThirdParty",$othermember->getFullName($langs),$othermember->login,$thirdparty->name), 'errors'); } } diff --git a/htdocs/adherents/fiche.php b/htdocs/adherents/fiche.php index e57e2b9eb1c7e..49eabe52d43e6 100644 --- a/htdocs/adherents/fiche.php +++ b/htdocs/adherents/fiche.php @@ -81,8 +81,6 @@ // Security check $result=restrictedArea($user,'adherent',$rowid,'','','fk_soc', 'rowid', $objcanvas); -$errmsg=''; $errmsgs=array(); - if ($rowid > 0) { // Load member @@ -128,7 +126,7 @@ if ($userid != $user->id && $userid != $object->user_id) { $error++; - $mesg='
'.$langs->trans("ErrorUserPermissionAllowsToLinksToItselfOnly").'
'; + setEventMessage($langs->trans("ErrorUserPermissionAllowsToLinksToItselfOnly"), 'errors'); } } @@ -164,7 +162,7 @@ $thirdparty=new Societe($db); $thirdparty->fetch($socid); $error++; - $errmsg='
'.$langs->trans("ErrorMemberIsAlreadyLinkedToThisThirdParty",$othermember->getFullName($langs),$othermember->login,$thirdparty->name).'
'; + setEventMessage($langs->trans("ErrorMemberIsAlreadyLinkedToThisThirdParty",$othermember->getFullName($langs),$othermember->login,$thirdparty->name), 'errors'); } } @@ -190,12 +188,12 @@ if ($result < 0) { $langs->load("errors"); - $errmsg=$langs->trans($nuser->error); + setEventMessage($langs->trans($nuser->error), 'errors'); } } else { - $errmsg=$object->error; + setEventMessage($object->error, 'errors'); } } @@ -211,13 +209,13 @@ if ($result < 0) { $langs->load("errors"); - $errmsg=$langs->trans($company->error); - $errmsgs=$company->errors; + setEventMessage($langs->trans($company->error), 'errors'); + setEventMessage($company->errors, 'errors'); } } else { - $errmsg=$object->error; + setEventMessage($object->error, 'errors'); } } @@ -231,7 +229,7 @@ $result=$object->send_an_email($langs->transnoentitiesnoconv("ThisIsContentOfYourCard")."\n\n%INFOS%\n\n",$langs->transnoentitiesnoconv("CardContent")); $langs->load("mails"); - $mesg=$langs->trans("MailSuccessfulySent", $from, $object->email); + setEventMessage($langs->trans("MailSuccessfulySent", $from, $object->email)); } } @@ -252,12 +250,12 @@ if ($morphy != 'mor' && empty($lastname)) { $error++; $langs->load("errors"); - $errmsg .= $langs->trans("ErrorFieldRequired",$langs->transnoentities("Lastname"))."
\n"; + setEventMessage($langs->trans("ErrorFieldRequired",$langs->transnoentities("Lastname")), 'errors'); } if ($morphy != 'mor' && (!isset($firstname) || $firstname=='')) { $error++; $langs->load("errors"); - $errmsg .= $langs->trans("ErrorFieldRequired",$langs->transnoentities("Firstname"))."
\n"; + setEventMessage($langs->trans("ErrorFieldRequired",$langs->transnoentities("Firstname")), 'errors'); } // Create new object @@ -343,7 +341,7 @@ $newfile=$dir.'/'.dol_sanitizeFileName($_FILES['photo']['name']); if (! dol_move_uploaded_file($_FILES['photo']['tmp_name'],$newfile,1,0,$_FILES['photo']['error']) > 0) { - $message .= '
'.$langs->trans("ErrorFailedToSaveFile").'
'; + setEventMessage($langs->trans("ErrorFailedToSaveFile"), 'errors'); } else { @@ -359,7 +357,7 @@ } else { - $errmsgs[] = "ErrorBadImageFormat"; + setEventMessage("ErrorBadImageFormat", 'errors'); } } else @@ -387,8 +385,11 @@ } else { - if ($object->error) $errmsg=$object->error; - else $errmsgs=$object->errors; + if ($object->error) { + setEventMessage($object->error, 'errors'); + } else { + setEventMessage($object->errors, 'errors'); + } $action=''; } } @@ -472,14 +473,14 @@ // Check parameters if (empty($morphy) || $morphy == "-1") { $error++; - $errmsg .= $langs->trans("ErrorFieldRequired",$langs->transnoentitiesnoconv("Nature"))."
\n"; + setEventMessage($langs->trans("ErrorFieldRequired",$langs->transnoentitiesnoconv("Nature")), 'errors'); } // Test si le login existe deja if (empty($conf->global->ADHERENT_LOGIN_NOT_REQUIRED)) { if (empty($login)) { $error++; - $errmsg .= $langs->trans("ErrorFieldRequired",$langs->trans("Login"))."
\n"; + setEventMessage($langs->trans("ErrorFieldRequired",$langs->trans("Login")), 'errors'); } else { $sql = "SELECT login FROM ".MAIN_DB_PREFIX."adherent WHERE login='".$db->escape($login)."'"; @@ -490,32 +491,32 @@ if ($num) { $error++; $langs->load("errors"); - $errmsg .= $langs->trans("ErrorLoginAlreadyExists",$login)."
\n"; + setEventMessage($langs->trans("ErrorLoginAlreadyExists",$login), 'errors'); } } if (empty($pass)) { $error++; - $errmsg .= $langs->trans("ErrorFieldRequired",$langs->transnoentities("Password"))."
\n"; + setEventMessage($langs->trans("ErrorFieldRequired",$langs->transnoentities("Password")), 'errors'); } } if ($morphy != 'mor' && empty($lastname)) { $error++; $langs->load("errors"); - $errmsg .= $langs->trans("ErrorFieldRequired",$langs->transnoentities("Lastname"))."
\n"; + setEventMessage($langs->trans("ErrorFieldRequired",$langs->transnoentities("Lastname")), 'errors'); } if ($morphy != 'mor' && (!isset($firstname) || $firstname=='')) { $error++; $langs->load("errors"); - $errmsg .= $langs->trans("ErrorFieldRequired",$langs->transnoentities("Firstname"))."
\n"; + setEventMessage($langs->trans("ErrorFieldRequired",$langs->transnoentities("Firstname")), 'errors'); } if (! ($typeid > 0)) { // Keep () before ! $error++; - $errmsg .= $langs->trans("ErrorFieldRequired",$langs->transnoentitiesnoconv("Type"))."
\n"; + setEventMessage($langs->trans("ErrorFieldRequired",$langs->transnoentitiesnoconv("Type")), 'errors'); } if ($conf->global->ADHERENT_MAIL_REQUIRED && ! isValidEMail($email)) { $error++; $langs->load("errors"); - $errmsg .= $langs->trans("ErrorBadEMail",$email)."
\n"; + setEventMessage($langs->trans("ErrorBadEMail",$email), 'errors'); } $public=0; if (isset($public)) $public=1; @@ -536,8 +537,11 @@ { $db->rollback(); - if ($object->error) $errmsg=$object->error; - else $errmsgs=$object->errors; + if ($object->error) { + setEventMessage($object->error, 'errors'); + } else { + setEventMessage($object->errors, 'errors'); + } $action = 'create'; } @@ -589,15 +593,18 @@ if ($result < 0) { $error++; - $errmsg.=$object->error; + setEventMessage($object->error, 'errors'); } } } else { $error++; - if ($object->error) $errmsg=$object->error; - else $errmsgs=$object->errors; + if ($object->error) { + setEventMessage($object->error, 'errors'); + } else { + setEventMessage($object->errors, 'errors'); + } } if (! $error) @@ -613,6 +620,8 @@ if ($user->rights->adherent->supprimer && $action == 'confirm_resign') { + $error = 0; + if ($confirm == 'yes') { $adht = new AdherentType($db); @@ -628,17 +637,23 @@ } if ($result < 0) { - $errmsg.=$object->error; + $error++; + setEventMessage($object->error, 'errors'); } } else { - if ($object->error) $errmsg=$object->error; - else $errmsgs=$object->errors; + $error++; + + if ($object->error) { + setEventMessage($object->error, 'errors'); + } else { + setEventMessage($object->errors, 'errors'); + } $action=''; } } - if (! empty($backtopage) && ! $errmsg) + if (! empty($backtopage) && ! $error) { header("Location: ".$backtopage); exit; @@ -652,7 +667,7 @@ { if (!$mailmanspip->del_to_spip($object)) { - $errmsg.= $langs->trans('DeleteIntoSpipError').': '.$mailmanspip->error."
\n"; + setEventMessage($langs->trans('DeleteIntoSpipError').': '.$mailmanspip->error, 'errors'); } } } @@ -663,7 +678,7 @@ { if (!$mailmanspip->add_to_spip($object)) { - $errmsg.= $langs->trans('AddIntoSpipError').': '.$mailmanspip->error."
\n"; + setEventMessage($langs->trans('AddIntoSpipError').': '.$mailmanspip->error, 'errors'); } } } @@ -725,9 +740,6 @@ print_fiche_titre($langs->trans("NewMember")); - dol_htmloutput_mesg($errmsg,$errmsgs,'error'); - dol_htmloutput_mesg($mesg,$mesgs); - if ($conf->use_javascript_ajax) { print "\n".'