Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Complementary User Attributes #23078

Open
karozans opened this issue Dec 2, 2022 · 5 comments
Open

Bug: Complementary User Attributes #23078

karozans opened this issue Dec 2, 2022 · 5 comments
Labels
Bug need more information This bug needs more information to be processed Discussion Some questions or discussions are opened and wait answers of author or other people to be processed

Comments

@karozans
Copy link

karozans commented Dec 2, 2022

Bug

The option for the Complementary User Attributes has an option under it for "Can always be edited" doesn't seem to have any effect.

Environment Version

16.0.3

Environment OS

Mac OS 13.0

Environment Web server

Apache 2.4.46

Environment PHP

PHP 7.4.21

Environment Database

MySQL 5.7.34

Environment URL(s)

/user/admin/user_extrafields.php

Expected and actual behavior

It should be expected if the checkbox is unchecked, it should not be editable.

However, it seems like to me that you should be allowed to put in a conditional statement for edit.

It would be nice to have some complementary attributes that the user cannot edit, but an admin or manager can.

Steps to reproduce the behavior

  1. Create a complementary attribute.
  2. Remove the check in the box for edit.
  3. Try to edit the attribute.

Attached files

No response

@karozans karozans added the Bug This is a bug (something does not work as expected) label Dec 2, 2022
@milenmk
Copy link
Contributor

milenmk commented Dec 2, 2022

"Can always be edited" when checked, should add a "pencil" to the field in view mode so it can be edited directly, without editing the card itself i.e. for fast edit of the field value for the currently viewed "card.php".

@karozans
Copy link
Author

karozans commented Dec 2, 2022

I see. I didn't know that's what that meant.

Don't you think there should be a field for editablity, the same as the field for visibility?

For instance. What if an admin creates an account for a non-admin, and they have a complementary attribute in the list for something like an employee number and they do not want the user to be able to edit this, but they want the user to be able to edit other fields in their own account?

@hregis
Copy link
Contributor

hregis commented Dec 2, 2022

@milenmk @karozans
for "extrafields" the "alwayseditable" parameter can only limit editing when the object is in "draft" mode

@ksar-ksar ksar-ksar added Discussion Some questions or discussions are opened and wait answers of author or other people to be processed and removed Bug This is a bug (something does not work as expected) labels Dec 9, 2022
@bos4711
Copy link
Contributor

bos4711 commented Sep 6, 2023

"Can always be edited" when checked, should add a "pencil" to the field in view mode so it can be edited directly, without editing the card itself i.e. for fast edit of the field value for the currently viewed "card.php".

I agree. Adding the "fast edit" feature for extrafields would be incredibly useful. In 17.x "Can always be edited" does not add the "fast edit", but I wish it did.

@ksar-ksar
Copy link
Contributor

Hello,

It is still the case with V18 ?

@ksar-ksar ksar-ksar added the Bug need more information This bug needs more information to be processed label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug need more information This bug needs more information to be processed Discussion Some questions or discussions are opened and wait answers of author or other people to be processed
Projects
None yet
Development

No branches or pull requests

5 participants