Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rest APi doesn't work after update from 3.1.1 to 5.0.1 #6881

Closed
chagam opened this issue May 23, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@chagam
Copy link

commented May 23, 2017

Bug

install version 3.1.1, install upgrades to 5.0.1
Activate 5.0.1 REST API module
try to get you token. Error message about classes cannot be declared as it already exist.
In version 5.0.1, old API files have been renamed from ex :
compta/facture/class/api_invoice.class.php
to
compta/facture/class/api_deprecated_invoice.class.php

and a new API file has been created :
compta/facture/class/api_invoices.class.php

But when you do the upgrade from 3.1.1, the files are not renamed nor deleted and you'll have :
compta/facture/class/api_invoice.class.php
compta/facture/class/api_deprecated_invoice.class.php
compta/facture/class/api_invoices.class.php

When you activate the REST API module, there's an error message because api_invoices.class.php causes an error because api_invoice.class.php has already been loaded with more or less same class definitions.

Environment

  • Version: 3.1.1 to 5.0.1
  • OS: Linux
  • Web server: Apache- PHP: [PHP version]
  • Database: Mysql

Expected and actual behavior

When upgrading, old and no longer necessary files should be deleted, archived or renamed. This is not the case actually and you end up with files that cause problem.

Steps to reproduce the behavior

Install 3.1.1, install upgrade to 4
then install upgrade to 5.0.1
activate REST API module and some modules such as "invoice", "users", "orders"
Try to get your token

Suggested implementation

during update, have a function that checks for no longer needed files

Suggested steps

  • Install old version,
  • do each upgrade one by one and after each update, list files that still exist in previous version and no longer exist in new version.
  • do a script that delete them, rename them or archive them when updating

@eldy eldy closed this in 85e0ded May 29, 2017

eldy added a commit that referenced this issue May 29, 2017

@chagam

This comment has been minimized.

Copy link
Author

commented May 29, 2017

the fix doesn't seem to include
\societe\class\api_contact.class.php
\societe\class\api_thirdparty.class.php
\categories\class\api_category.class.php
\product\class\api_product.class.php

these files cause problem too. There doesn't seem to have other deprecated files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.