New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSS by using "onclick" #8000

Open
Snowty opened this Issue Dec 29, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@Snowty

Snowty commented Dec 29, 2017

Bug

The xss filter in "htdocs/main.inc.php" is not enough, we can just use "onclick" and "onscroll" to bypass the filter,eg:
<div style="position:absolute;top:0;left:0;width:100%;height:100%" onclick="alert(52)"> ,
<body onscroll=alert(1)><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><input autofocus>,
and then we can inject the arbitrary code in many input forms.

Poc

image

image

Fix

Add the "onclick"、"onscroll" in the black list, and escape the "<",etc.

@frederic34

This comment has been minimized.

Show comment
Hide comment
@frederic34
Contributor

frederic34 commented Feb 4, 2018

@fgeek

This comment has been minimized.

Show comment
Hide comment
@fgeek

fgeek Feb 22, 2018

@frederic34 should this issue be closed or are additional commits expected?

fgeek commented Feb 22, 2018

@frederic34 should this issue be closed or are additional commits expected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment