Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

# New multi-currency exchange rate editor #15117

Merged
merged 6 commits into from Oct 31, 2020

Conversation

atm-jpb
Copy link
Contributor

@atm-jpb atm-jpb commented Oct 23, 2020

Context

Currently multicurrency logs past exchange rates when you "update" the exchange rate of a currency, but it doesn't enable you to correct past exchange rates or to date an exchange rate when you add it (the date is automatically set to the current time).

This PR

This PR introduces a new page that enables you to view, edit or add exchange rates in a way somewhat similar to Dolibarr dictionaries. The page is accessible via the administration module.

image

@atm-jpb
Copy link
Contributor Author

atm-jpb commented Oct 23, 2020

@eldy : have some error message from stickler-ci "Could not fetch pull request branch". i have no clue how to fix this one.
have you any direction ?

@atm-jpb
Copy link
Contributor Author

atm-jpb commented Oct 26, 2020

@eldy hello i come back to you with my message from stickler-ci "Could not fetch pull request branch".

@eldy
Copy link
Member

eldy commented Oct 27, 2020

You can ignore stickler-ci errors. It is not important.
However, the errors into Travis CI are important. Fixing them is mandatory.

@eldy eldy added the PR to fix or conflict to solve PR needs to be fixed to be integrated (except for conflicts, a comment describes the fix to do) label Oct 27, 2020
@atm-jpb
Copy link
Contributor Author

atm-jpb commented Oct 27, 2020

@eldy conflict solved

@atm-jpb
Copy link
Contributor Author

atm-jpb commented Oct 28, 2020

@eldy if i understand the PR process , this one is ok to your human review ?

@eldy eldy merged commit 11f9c4c into Dolibarr:develop Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR to fix or conflict to solve PR needs to be fixed to be integrated (except for conflicts, a comment describes the fix to do)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants