Limitation of rights to modify HR informations on their own profile #23700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Jan 30, 2023
htdocs/user/card.php
Outdated
| @@ -2791,7 +2792,11 @@ | |||
| // Salary | |||
| print '<tr><td>'.$langs->trans("Salary").'</td>'; | |||
| print '<td>'; | |||
| print img_picto('', 'salary', 'class="pictofixedwidth paddingright"').'<input size="8" type="text" name="salary" value="'.price2num(GETPOST('salary') ?GETPOST('salary') : $object->salary).'">'; | |||
| if ($caneditsensitivedata) { | |||
There was a problem hiding this comment.
The salary is not a data on the control of the user. So i think it should be managed by the permission on the salary or rh module (generally owned by HR people). Not by a permission on users (generally owned by admin).
There was a problem hiding this comment.
what do you think about using user->right->salaries->write for the salary field and user->rights->hrm->write_personal_information->write for the others (job, weekly hours, tjm, thm,dateemployment and dateemploymentend) ?
There was a problem hiding this comment.
@eldy is this Ok for you ?
eldy
added
the
Discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX
Limitation of rights to modify HR informations (salaries, daily rate, hourly rate, position held, date of entry, etc.) on their own profile so that a simple employee can access it without however being able to modify it
A user with the right user->self->creer but not having the right user->user->creer will not be able to modify his position, his salary, his tjm and thm as well as his date of entry.