NEW hook formConfirm always called if hooked

[ksar-ksar]

Actualy the hook formConfirm is called only if the variable $formconfirm is empty.
So it is called when there is NO formConfirm.
I think that the test should be if the $formconfirm is not empty

[frederic34]

A module can add a formconfirm if $formconfirm is empty, if you change that module can't add formconfirm 😟

[ksar-ksar]

Dear Frederic,

I do not see when you could use this, and I do not think this was the goal of the Hook.
When you have a look on the rest of the code, you have the possibility to add a code to the existing formconfirm : if (empty($reshook)) $formconfirm.=$hookmanager->resPrint;
So if formconfirm is allways empty this line is there for nothing !

For me the test should be changed !

[eldy]

Yes the hook is called only if the variable $formconfirm is empty.
This is the expected behaviour. So if it is empty, we call the hook to implement the case when it is empty to fill it.
What is goal of calling it when it is already defined ?

[frederic34]

https://www.dolibarr.fr/forum/511-creation-dun-nouveau-module/62476-question-sur-le-hook-formconfirm

[ksar-ksar]

Following the discussion we have, the best approch will be to remove the test if (! $formconfirm) and to allways call the hook.