Skip to content

[IDEV-2473] DomainTools Feeds: fix rawJSON for domainrisk and domainhotlist feeds #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
briluza merged 1 commit into from
Apr 23, 2026
Merged

[IDEV-2473] DomainTools Feeds: fix rawJSON for domainrisk and domainhotlist feeds #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 34 additions & 10 deletions Packs/FeedDomainTools/Integrations/FeedDomainTools/FeedDomainTools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,17 +161,36 @@ def build_iterator(self, feed_type: str = "nod", dt_feed_kwargs: dict = {}) -> I
# for `domainrdap` feed, we have more data to display including the parsed data.
parsed_record = json_feed.get("parsed_record", {})
overall_risk_score = json_feed.get("overall_risk", None)
risk_score_details = None

dt_feed_data = {
"value": indicator,
"type": indicator_type,
"timestamp": timestamp,
"tags": ["DomainToolsFeeds", self.feed_type] + ud_tags,
"tlp_color": self.tlp_color,
"parsed_record": parsed_record,
"overall_risk_score": overall_risk_score,
}

# for domaihotlist & domainriks feed, we will be returning the risk scores
if self.feed_type in (self.DOMAINRISK, self.DOMAINHOTLIST):
risk_score_details = {
"phishing_risk": json_feed.get("phishing_risk"),
"malware_risk": json_feed.get("malware_risk"),
"spam_risk": json_feed.get("spam_risk"),
"proximity_risk": json_feed.get("proximity_risk"),
"overall_risk": json_feed.get("overall_risk"),
}

if self.feed_type == self.DOMAINHOTLIST:
risk_score_details["expires"] = json_feed.get("expires")

# update the parsed dt feed data
dt_feed_data["risk_score_details"] = risk_score_details

if indicator and indicator_type:
yield {
"value": indicator,
"type": indicator_type,
"timestamp": timestamp,
"tags": ["DomainToolsFeeds", self.feed_type] + ud_tags,
"tlp_color": self.tlp_color,
"parsed_record": parsed_record,
"overall_risk_score": overall_risk_score,
}
yield dt_feed_data

limit_counter += 1
processed_feeds += 1
Expand Down Expand Up @@ -244,6 +263,7 @@ def fetch_indicators(client: DomainToolsClient, feed_type: str = "nod", dt_feed_
tlp_color_ = item.get("tlp_color")
parsed_record_ = item.get("parsed_record")
overall_risk_score_ = item.get("overall_risk_score")
risk_score_details_ = item.get("risk_score_details")

indicator_tags = ",".join(tags_).rstrip(",")

Expand All @@ -256,6 +276,9 @@ def fetch_indicators(client: DomainToolsClient, feed_type: str = "nod", dt_feed_
if parsed_record_:
raw_data["parsed_record"] = parsed_record_

if risk_score_details_:
raw_data["risk_score_details"] = risk_score_details_

# Create indicator object for each value.
indicator_obj = {
"value": value_,
Expand Down Expand Up @@ -374,7 +397,8 @@ def test_module(client: DomainToolsClient, args: dict[str, str], params: dict[st
"""
dt_feed_kwargs = {"top": 1, "after": None}

feed_type_ = params.get("feed_type", "NOD")
feed_type_ = params.get("feed_type", "nod")
feed_type_ = "nod" if feed_type_ == "ALL" else feed_type_
try:
next(client.build_iterator(feed_type=feed_type_, dt_feed_kwargs=dt_feed_kwargs))
except Exception as e:
Expand Down
53 changes: 49 additions & 4 deletions Packs/FeedDomainTools/Integrations/FeedDomainTools/test_data/feed_mock_response.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,6 +791,13 @@
"value": "resmiguncelsite.com",
"type": "Domain",
"timestamp": "2025-09-06T21:18:06Z",
"risk_score_details": {
"phishing_risk": 99,
"malware_risk": 99,
"spam_risk": 99,
"proximity_risk": 100,
"overall_risk": 100,
},
},
"score": 3
},
Expand All @@ -807,8 +814,15 @@
"value": "bpi-cye.co",
"type": "Domain",
"timestamp": "2025-09-06T21:42:06Z",
"risk_score_details": {
"phishing_risk": 99,
"malware_risk": 99,
"spam_risk": 99,
"proximity_risk": 100,
"overall_risk": 45,
},
},
"score": 1
"score": 1
},
{
"value": "antthrobchannel.com",
Expand All @@ -823,8 +837,15 @@
"value": "antthrobchannel.com",
"type": "Domain",
"timestamp": "2025-09-06T21:12:06Z",
"risk_score_details": {
"phishing_risk": 99,
"malware_risk": 99,
"spam_risk": 99,
"proximity_risk": 100,
"overall_risk": 63,
},
},
"score": 2
"score": 2
}
]

Expand All @@ -842,6 +863,14 @@
"value": "scmipgf.icu",
"type": "Domain",
"timestamp": "2025-09-06T22:27:06Z",
"risk_score_details": {
"phishing_risk": 99,
"malware_risk": 99,
"spam_risk": 99,
"proximity_risk": 100,
"overall_risk": 100,
"expires": "2025-09-07T11:34:51Z",
},
},
"score": 3
},
Expand All @@ -858,8 +887,16 @@
"value": "growth-hacker-ppc.com",
"type": "Domain",
"timestamp": "2025-09-06T22:26:49Z",
"risk_score_details": {
"phishing_risk": 99,
"malware_risk": 99,
"spam_risk": 99,
"proximity_risk": 100,
"overall_risk": 100,
"expires": "2025-09-07T19:19:29Z",
},
},
"score": 1
"score": 3
},
{
"value": "gq5zn0u.top",
Expand All @@ -874,7 +911,15 @@
"value": "gq5zn0u.top",
"type": "Domain",
"timestamp": "2025-09-06T22:26:55Z",
"risk_score_details": {
"phishing_risk": 99,
"malware_risk": 99,
"spam_risk": 99,
"proximity_risk": 100,
"overall_risk": 100,
"expires": "2025-09-07T11:53:17Z",
},
},
"score": 2
"score": 3
}
]
Loading