From 3294cc247e48c3e6f9b7bbf2d1f4be7f0dabf644 Mon Sep 17 00:00:00 2001 From: Andrew Arnott Date: Tue, 26 Feb 2013 22:10:30 -0800 Subject: [PATCH 1/2] Fixes log message when return_to match failures occur. Fixes #249 --- .../OpenId/Messages/IndirectSignedResponse.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/DotNetOpenAuth.OpenId/OpenId/Messages/IndirectSignedResponse.cs b/src/DotNetOpenAuth.OpenId/OpenId/Messages/IndirectSignedResponse.cs index 8bceb680dc..1242b20f8a 100644 --- a/src/DotNetOpenAuth.OpenId/OpenId/Messages/IndirectSignedResponse.cs +++ b/src/DotNetOpenAuth.OpenId/OpenId/Messages/IndirectSignedResponse.cs @@ -404,8 +404,8 @@ internal IndirectSignedResponse(Version version, Uri relyingPartyReturnTo) IsQuerySubsetOf(this.Recipient.Query, this.ReturnTo.Query), OpenIdStrings.ReturnToParamDoesNotMatchRequestUrl, Protocol.openid.return_to, - this.ReturnTo, - this.Recipient); + this.ReturnTo.AbsoluteUri, + this.Recipient.AbsoluteUri); } } } From 3b01b4143c59d3da9839638eb8cc7036861401fb Mon Sep 17 00:00:00 2001 From: Andrew Arnott Date: Mon, 25 Nov 2013 10:20:13 -0800 Subject: [PATCH 2/2] Applies fix for #209 to one more entrypoint for parsing XML that was missed initially. --- src/DotNetOpenAuth.OpenId/Xrds/XrdsDocument.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/DotNetOpenAuth.OpenId/Xrds/XrdsDocument.cs b/src/DotNetOpenAuth.OpenId/Xrds/XrdsDocument.cs index 0e1ecc176e..a0c59c4b88 100644 --- a/src/DotNetOpenAuth.OpenId/Xrds/XrdsDocument.cs +++ b/src/DotNetOpenAuth.OpenId/Xrds/XrdsDocument.cs @@ -54,7 +54,7 @@ public XrdsDocument(XmlReader reader) /// The text that is the XRDS document. [SuppressMessage("Microsoft.Reliability", "CA2000:Dispose objects before losing scope", Justification = "Fixing would decrease readability, and not likely avoid any finalizer on a StringReader anyway.")] public XrdsDocument(string xml) - : this(new XPathDocument(new StringReader(xml)).CreateNavigator()) { } + : this(new XPathDocument(XmlReader.Create(new StringReader(xml), MessagingUtilities.CreateUntrustedXmlReaderSettings())).CreateNavigator()) { } /// /// Gets the XRD child elements of the document.