Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FollowPlayerScript Mouse Rotation #133

Merged

Conversation

Projects
None yet
5 participants
@Ronnrein
Copy link
Contributor

commented Feb 26, 2014

Updated FollowPlayerScript with mouse drag-rotation with hangtime, allowing player to look around freely. Camera will center again after set seconds after mouse is released.

rot

Also cleaned up indentation to match the rest of the project.

@elneilios

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2014

Nice. Was just thinking this was needed.

@elneilios

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2014

One suggestion. Try using InControl library for moving the camera instead so that you can also use a gamepad thumbstick. See InControlSwingMode.cs and SwingModeProfile.cs for example

@Ronnrein

This comment has been minimized.

Copy link
Contributor Author

commented Feb 26, 2014

Thanks a lot for the suggestion! Added this now, tested it with my controller and works fine.

@thegsm

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2014

It works well as described. We probably also need a way to reset the view, I got confused very quickly, but that could be handled via a different issue.

@Ronnrein

This comment has been minimized.

Copy link
Contributor Author

commented Feb 27, 2014

Thanks for the suggestion, added this now.

rot

Found out my controller is not officially supported by InControl, so my original analog script might not work on officially supported controllers. Fixed this now, analog should now work on both supported and unsupported controllers. I have no way to test this right now so any feedback on that would be appreciated! Reset button however should not work, as there is no sensible mapping for unsupported controllers.

@Cheeseness

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2014

Hmm, any chance you could lodge an upstream issue for support on InControl's GitHub repo for support for your controller?

Would be great to keep everything using the one input system.

@Cheeseness

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2014

@Lokno, would you mind chiming in here as well?

@Lokno

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2014

Could we use the input manager to support gamepad and mouse for this feature? Add horizontal2 and vertical2? I haven't yet messed with InControl myself.

Edit: I tested the proposed script and I like that it works well with the lean feature.

@Cheeseness

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2014

Alrighty, well I'll merge this for now and we can refactor later as needed :)

Cheeseness added a commit that referenced this pull request Feb 27, 2014

@Cheeseness Cheeseness merged commit c33e2bd into Double-Fine-Game-Club:master Feb 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.