Douwe Maan DouweM

Organizations

@gitlabhq @toopia
DouweM commented on pull request jneen/rouge#297
@DouweM

@rumpelsepp It didn't, it does now :)

@DouweM
  • @DouweM dadc656
    Don't render '---' in email patches as deleted
DouweM opened pull request jneen/rouge#297
@DouweM
Fix diff lexer highlighting of deleted lines.
1 commit with 2 additions and 6 deletions
DouweM created branch fix-diff at DouweM/rouge
DouweM commented on issue gitlabhq/gitlabhq#9495
@DouweM

@stanhu <3

DouweM commented on issue gitlabhq/gitlabhq#9495
@DouweM

It would appear that resources are being created outside the RSpec before/after cycle. We know this is possible with JS specs, which is why we use D…

DouweM pushed to master at gitlabhq/grit
@DouweM
DouweM merged pull request gitlabhq/grit#53
@DouweM
update(gems): update mime-types gem to 2.6
1 commit with 4 additions and 4 deletions
@DouweM
DouweM merged pull request DouweM/mengpaneel#7
@DouweM
Improve Readme for initializer
1 commit with 2 additions and 2 deletions
DouweM commented on pull request DouweM/mengpaneel#7
@DouweM

Thanks @tibastral! I realize that wasn't really clear.

@DouweM
@DouweM
  • @DouweM f75cd02
    Convex Solutions has ended :(
DouweM commented on pull request iain/http_accept_language#47
@DouweM

@theodorton Apologies for the slow review! Life gets in the way and things like that. Looks good to me, apart from the typo @isaacseymour spotted; …

@DouweM
Edit on web interface adds carriage returns to file.
DouweM commented on pull request gitlabhq/gitlab_git#52
@DouweM
@DouweM
DouweM merged pull request gitlabhq/gitlab_git#52
@DouweM
Add new method to Gitlab::Git::Repository
1 commit with 23 additions and 0 deletions
DouweM commented on pull request gitlabhq/gitlab_git#52
@DouweM

@jacobvosmaer Confirmed to work. I'm merging this, and going through the motions to get this into gitlab-ce and use it there.

@DouweM
DouweM commented on pull request gitlabhq/gitlabhq#9373
DouweM merged pull request gitlabhq/gitlabhq#9373
@DouweM
Revert "No need to check if `repository_ref` is present"
1 commit with 5 additions and 1 deletion
DouweM commented on pull request gitlabhq/gitlabhq#9368
@DouweM

@jvanbaarsen Revert, please. The repository_ref seems to originate in a param, so it could very well be an empty string, in which case we want to t…

DouweM commented on pull request gitlabhq/gitlabhq#9368
@DouweM

@stanhu is right. There's also most likely a reason why the check was added. @zenati please double check that this doesn't break (or otherwise cha…

@DouweM

What's the possible breaking change? I'd like to upgrade to rotp 2.1.1 since it includes this fix: mdp/rotp#43.

DouweM commented on pull request mdp/rotp#43
@DouweM

@mdp Thank you, much appreciated.

DouweM opened pull request mdp/rotp#43
@DouweM
Reverse order of secret and issuer params in provisioning URL.
1 commit with 1 addition and 1 deletion