Fixed #45 #46

Merged
merged 6 commits into from Jan 3, 2013

2 participants

@Spikhalskiy

This changes fixed issue #45

@buzdin

Why extract a separate test case class?

@buzdin Because tests from this test case test only static method and the are not required any prepared startup method to create a mapping processor. I usually separate such suites. If you think that it should be one test case - I can merge them.

DozerMapper member

I usually maintain strict class/test naming convention for unit tests. This helps to switch between code and tests easily. The best option would be to refactor MappingProcessor and extract static methods to separate class, which will result in a separate test case as well. Please do merge them back for now.

@buzdin

I would not use issue numbers in the code since issue trackers come and go, but Dozer remains :)
Would be great to change to meaningful names instead (even if they are long)

Ok, no problem.

Done :)

@buzdin
DozerMapper member

This would be great as a separate change list as not directly related, but no problems.

I agree. You can fix it in master and I merge your changes to my branch if you wish.

DozerMapper member

No need for that. Just have to remember to write it in release notes and close according issue.

@buzdin buzdin merged commit 6b53af5 into DozerMapper:master Jan 3, 2013

1 check passed

Details default The Travis build passed
@Spikhalskiy Spikhalskiy deleted the Spikhalskiy:issue-45 branch Jan 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment