Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Adapter suggestion #20

Closed
jo-lee opened this Issue · 1 comment

2 participants

jo-lee Olivier Philippon
jo-lee

In order to make the Adapter escape() work, I have to change the following:

// else if( isNaN(value) || value === '' )
else if( typeof(value)=="string" )
return "'" + value.replace(/'/g, "''") + "'";

It is because some strings contain numeric digits such as "1234" cannot be escaped
due to isNaN("1234") gives false!

Olivier Philippon DrBenton closed this issue from a commit
Olivier Philippon Fixed #20
* more accurate String params escaping
b044b14
Olivier Philippon DrBenton closed this in b044b14
Olivier Philippon
Owner

@jo-lee Thank you very much for this suggestion !
I've just added a unit test for that, and fixed the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.