This repository has been archived by the owner. It is now read-only.

Where parenthesis #4

Merged
merged 3 commits into from Aug 14, 2012

Conversation

Projects
None yet
2 participants
Collaborator

kalifg commented Aug 14, 2012

I added parenthesis to the where clauses like we discussed. I also updated the unit tests and the README.

There was a bug in .where() involving passing it an array for value. It just needed some added parenthesis.

kalifg added some commits Aug 14, 2012

This update will cause all where clauses to be parenthesized, allowing
one to group compound statements such as .where('id=? OR name=?) which
the same grouping expectations as they would have with ZendDb.

Updated tests and README for proposed changes.
Added new test dealing with compound where clauses and array values.
Updated README with information about supplying array values to
.where().

Fixed bug in .where() so that array values are treated as they are in
ZendDb, with the possible exception that we are not restricting what
clauses they can be supplied to.

Tests pass.

DrBenton added a commit that referenced this pull request Aug 14, 2012

@DrBenton DrBenton merged commit ba044b1 into DrBenton:master Aug 14, 2012

Owner

DrBenton commented Aug 14, 2012

Perfect!
Thank you very much for this new feature... and for your kindness :-)

Owner

DrBenton commented Aug 14, 2012

...pushed to NPM registry as well : https://npmjs.org/package/node-dbi

Collaborator

kalifg commented Aug 14, 2012

It was a pleasure!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.