Some +8xx ranges can be stubbed using libphonenumber data but aren't

[theory]

These tests will fail:

my $toll_free = '+1 (866) 623 2282';
my $tf = Number::Phone::Lib->new($toll_free);
isa_ok $tf, 'Number::Phone::StubCountry::US';
is($tf->country_code(), 1, "Number::Phone::Lib->new('$toll_free')->country_code()");
is($tf->country(), 'US', "Number::Phone::Lib->new('$the_man')->country()");
is($tf->areaname(), undef, "Number::Phone::Lib->new('$toll_free')->areaname()");
is($tf->format, '+1 866 623 2282', "Number::Phone::Lib->new('$toll_free')->format()");

I suspect it's because international toll-free numbers are ignored by this code in build-data.stubs:

  if($ISO_country_code !~ /^..$/) {
    warn("skipping 'country' $ISO_country_code (+$IDD_country_code)\n");
    next TERRITORY;
  }

Can we restore this and get the country lookup to recognize toll-fee numbers?

[DrHyde]

Would you like a commit bit? :-)

[theory]

Oy, no. Just need validation and formatting working properly at work. I don't care about any of the rest of it. :-)

[DrHyde]

I merged your PR which fixes this

[theory]

Er, no, I did not fix this in #16. The toll-free number "country codes" are still skipped in build-data.stubs:

  if($ISO_country_code !~ /^..$/) {
    warn("skipping 'country' $ISO_country_code (+$IDD_country_code)\n");
    next TERRITORY;
  }

[DrHyde]

Ah, OK, I was confused because the test is for a +1-8xx number, not a +8xx number

[theory]

Me too!

[DrHyde]

... and closed again, because they get instantiated as N::P::StubCountry

[theory]

Is that okay? Should they not get formats associated with them? For example, 800:

<territory id="001" countryCode="800" leadingZeroPossible="true">
  <availableFormats>
    <numberFormat pattern="(\d{4})(\d{4})">
      <format>$1 $2</format>
    </numberFormat>
  </availableFormats>

[DrHyde]

This is a nice-to-have, but there are architectural problems in N::P::Country[::Data].

Never mind the repetition of data, but it also assumes that each "country" has at most one country code. InternationalNetworks has 2, and Inmarsat has 5.

libphonenumber only knows about one of Inmarsat's codes (the other four are old and being replaced by the the new one, but I think are still in service), but it does know about +882 and +883. When I add support for these, need to have thorough tests for 882/883.

[theory]

Thanks. The US-style toll-free numbers are good enough for me, since we require country codes for all numbers, anyway.

[DrHyde]

I just had a mailing list created for Number::Phone users: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/number-phone

[DrHyde]

working on this in branch add-8xx-ranges

[DrHyde]

Pull request #114

[DrHyde]

Merged and will be in the next release