Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CPAN Module #50

Closed
juliogreff opened this issue Oct 23, 2015 · 6 comments
Closed

Update CPAN Module #50

juliogreff opened this issue Oct 23, 2015 · 6 comments

Comments

@juliogreff
Copy link

Probably one of my colleagues contacted you before about the CPAN module version :)

Brazil recently added a new digit to their cellphone numbers. libphonenumbers is up to date, could you please updated the CPAN module? I have the data in my fork of the repo if that helps you in any way.

Thanks!

@DrHyde
Copy link
Owner

DrHyde commented Oct 26, 2015

Thanks for letting me know, I'll get that done this week.

Can you give me an example number so I can add a test for it?

@juliogreff
Copy link
Author

Thanks a lot!

Example numbers:

  • Should pass validation: +55 35 9 98 70 56 56
  • Shouldn't pass validation anymore: +55 35 98 70 56 56 (the first 9 after the area code is is now required, so old numbers are invalid)

@DrHyde
Copy link
Owner

DrHyde commented Oct 26, 2015

Hmm according to the libphonenumber regex the first 9 in that number is optional, so both validate OK. Note the 9? here.

@DrHyde
Copy link
Owner

DrHyde commented Oct 26, 2015

I had a look on the ITU website and it's a bit confusing. It indicates that libphonenumber might be Very Wrong - you should probably take this up with them. In the mean time, I'll do a release that will at least accept the new numbers with the extra digit.

@juliogreff
Copy link
Author

The 9 being optional is acceptable for us for the moment, since it's a human (and usually a Brazilian human) picking up the phone and dialing, but we'll take it up with them indeed. We'll be waiting for the release. Thanks a lot!

@DrHyde
Copy link
Owner

DrHyde commented Oct 27, 2015

3.0012 is on the CPAN now.

@DrHyde DrHyde closed this as completed Oct 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants