Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NZ mobile numbers have changed format #96

Closed
dr-kd opened this issue Apr 27, 2020 · 3 comments
Closed

NZ mobile numbers have changed format #96

dr-kd opened this issue Apr 27, 2020 · 3 comments

Comments

@dr-kd
Copy link

dr-kd commented Apr 27, 2020

see https://github.com/google/libphonenumber/blob/master/resources/PhoneNumberMetadata.xml#L22048

associated with libphonenumber 8.12.1

I'm seeing problems like this in the wild.

@dr-kd
Copy link
Author

dr-kd commented Apr 27, 2020

looks like a rebuild Makefile.PL && make dist fixes the problem. Although it'd be nice not to have to rely on my own build.

@DrHyde
Copy link
Owner

DrHyde commented Apr 27, 2020

That's what my fix will be, hopefully later today :-)

I would like to provide a better way for users to update their own installations, but whatever I do would be unreliable, as it would depend on:

  • updated data not requiring any changes to the tests;
  • google not changing the data format in libphonenumber

@DrHyde
Copy link
Owner

DrHyde commented Apr 27, 2020

This should be fixed in 3.6003, which is on its way to the CPAN as we speak.

@DrHyde DrHyde closed this as completed Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants