New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unintentional UK mode #47

Merged
merged 2 commits into from Oct 16, 2015

Conversation

Projects
None yet
2 participants
@mjg17
Contributor

mjg17 commented Oct 14, 2015

In adding the Åland Islands to Finland, I discovered a bug: any use of Number::Phone or of a stub country based on Number::Phone::StubCountry sets UK mode for Number::Phone::Country (and calling phone2country on a code which has multiple resolutions will cause stub country modules to be loaded).

The first commit is a failing test; the second is a fix.

The Åland Islands - AX - will be coming in a second data update patch at some stage.

(Test 41 is failing for me on master and after this patch, on subtests 97 and 117. I haven't investigated.)

@DrHyde

This comment has been minimized.

Show comment
Hide comment
@DrHyde

DrHyde Oct 16, 2015

Owner

I fixed those failing tests so you might want to merge master into your branch

Owner

DrHyde commented Oct 16, 2015

I fixed those failing tests so you might want to merge master into your branch

DrHyde added a commit that referenced this pull request Oct 16, 2015

@DrHyde DrHyde merged commit 6288a34 into DrHyde:master Oct 16, 2015

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
coverage/coveralls Coverage remained the same at 86.424%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment