New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: prefer is() to ok() #48

Merged
merged 4 commits into from Oct 16, 2015

Conversation

Projects
None yet
2 participants
@mjg17
Contributor

mjg17 commented Oct 14, 2015

I was niggled by trying to find out the details of a test failure I'd provoked, and then got the fixing bug...

DrHyde added a commit that referenced this pull request Oct 16, 2015

@DrHyde DrHyde merged commit 26bd946 into DrHyde:master Oct 16, 2015

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
coverage/coveralls Coverage remained the same at 86.424%
Details
@DrHyde

This comment has been minimized.

Show comment
Hide comment
@DrHyde

DrHyde Oct 16, 2015

Owner

Thanks!

On a similar note, may I recommend Test::Differences::eq_or_diff as a much better alternative to Test::More::is_deeply? I tend to only use it in debuggering though and not add it to everything as yet another dependency.

Owner

DrHyde commented Oct 16, 2015

Thanks!

On a similar note, may I recommend Test::Differences::eq_or_diff as a much better alternative to Test::More::is_deeply? I tend to only use it in debuggering though and not add it to everything as yet another dependency.

@mjg17

This comment has been minimized.

Show comment
Hide comment
@mjg17

mjg17 Oct 16, 2015

Contributor

Oh yes, I've used eq_or_diff, very handy!

And good call on bumping the required version of Test::More for subtests, I didn't think to check that.

Contributor

mjg17 commented Oct 16, 2015

Oh yes, I've used eq_or_diff, very handy!

And good call on bumping the required version of Test::More for subtests, I didn't think to check that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment