New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept a hashref as first arg for validate [PRC] #9

Merged
merged 1 commit into from Jul 11, 2018

Conversation

Projects
None yet
3 participants
@jjatria
Contributor

jjatria commented Jun 21, 2018

This makes the behaviour of the overriden validate more closely resemble that of the original package's.

Since we are testing for the absence of a warning, this does include adding a test dependency on Test::Warnings, but this could be removed if the test was redesigned.

This fixes #3.

@jjatria jjatria changed the title from Accept a hashref as first arg for validate. Fix #2 [PRC] to Accept a hashref as first arg for validate. Fix #3 [PRC] Jun 21, 2018

@jjatria jjatria changed the title from Accept a hashref as first arg for validate. Fix #3 [PRC] to Accept a hashref as first arg for validate [PRC] Jun 21, 2018

@coveralls

This comment has been minimized.

coveralls commented Jun 21, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 9e65ca7 on jjatria:validate-hashref into b212057 on DrHyde:master.

@DrHyde DrHyde merged commit 65babbc into DrHyde:master Jul 11, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@DrHyde

This comment has been minimized.

Owner

DrHyde commented Jul 11, 2018

thanks, merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment