Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for reading NFC tags #1382

Closed
wants to merge 1 commit into from
Closed

Add support for reading NFC tags #1382

wants to merge 1 commit into from

Conversation

@zeehio
Copy link

@zeehio zeehio commented Jan 4, 2016

This commit adds support for reading and parsing NFC tags. For instance, an NFC tag with "tg:msg?text=Hello" as URI, is now detected and processed.

Manifest changes:

  • Uses feature NFC
  • Uses permission NFC
  • Declares intent for NFC tags with scheme "tg"

LaunchActivity changes:

  • Move logic to parse telegram URIs from handleIntent method to its own class: ui/UriAction.java. This allows to use the same code from written URLs and NFC tags.
  • Add logic to parse NDEF records.

UriAction.java: New class to parse actions triggered by URIs.

- Move logic to parse telegram URIs from handleIntent method to ui/UriAction.java
- Allow reading telegram URI directly from NFC tag. Eg. tg://msg?text=Hello
@MrDyro

This comment has been minimized.

What about an @IntDef instead of an enum?

Copy link

@sergeysova sergeysova left a comment

Resolve conflicts, please

@zeehio
Copy link
Author

@zeehio zeehio commented Oct 22, 2016

@lestad this Pull Request (like many others) has been blatantly ignored for many months now. As you may understand this is quite frustrating.

I won't move a finger to rebase this pull request unless there is a commitment to add this feature to telegram. Even if that commitment existed I don't know when I will have time to do that.

Now you pop up, without any kind of explanation of your relation to the telegram project, asking me to spend time working on something that I don't have any clue if it will be ever merged.

So answer me this, please: Why should I care to resolve conflicts?

Unless there is a good answer to that question feel free to resolve conflicts yourself. The branch is public.

@zeehio
Copy link
Author

@zeehio zeehio commented Aug 27, 2018

After more than two years, I'm closing this and unsubscribing myself from the PR.

@zeehio zeehio closed this Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants