New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

u3d/unity_versions: fix missing latest versions #335

Merged
merged 4 commits into from Jan 8, 2019

Conversation

Projects
None yet
2 participants
@niezbop
Copy link
Member

niezbop commented Dec 5, 2018

Pull Request Checklist

  • My pull request has been rebased on master
  • I ran bundle exec rspec to make sure that my PR didn't break any test
  • I ran bundle exec rubocop to make sure that my PR is inline with our code style
  • I have read the code of conduct

Pull Request Description

Unity has recently updated their listing of the latest releases for betas notably.
This restore the functionnality by fetching the latest information.

Fixes #330

u3d/unity_versions: fix missing latest versions
Unity has recently updated their listing of the latest releases for betas notably.
This restore the functionnality by fetching the latest information.

@niezbop niezbop requested a review from lacostej Dec 5, 2018

@niezbop niezbop added the bug label Dec 5, 2018

niezbop added some commits Dec 5, 2018

expect(U3d::UnityVersions).to receive(:fetch_version_paged).at_least(3).times { {} }
expect(U3d::UnityVersions).to receive(:fetch_version).at_least(3).times { {} }
expect(U3d::UnityVersions).to receive(:fetch_from_json).at_least(:once) { {} }
expect(U3d::UnityVersions.list_available(os: :win).count).to eql 0

This comment has been minimized.

@lacostej

lacostej Jan 8, 2019

Member

why 0 available?

This comment has been minimized.

@lacostej

lacostej Jan 8, 2019

Member

maybe we want to rename the description (i.e. to "it retrieves from various sources") or something more related to what we now test here.

expect(U3d::UnityVersions).to receive(:fetch_version_paged).at_least(6).times { {} }
expect(U3d::UnityVersions).to receive(:fetch_version).at_least(6).times { {} }
expect(U3d::UnityVersions).to receive(:fetch_from_json).at_least(:once) { {} }
expect(U3d::UnityVersions.list_available(os: :mac).count).to eql 0

This comment has been minimized.

@lacostej
end

# TODO: test U3d::UnityVersions.fetch_version_paged
xdescribe '.fetch_version_paged' do

This comment has been minimized.

@lacostej

lacostej Jan 8, 2019

Member

needed?

@@ -114,6 +114,8 @@ module UnityVersions
UNITY_BETAS = 'https://unity3d.com/unity/beta/archive'.freeze

This comment has been minimized.

@lacostej

lacostej Jan 8, 2019

Member

if this is broken fully, then either we document this isn't used (and change the content) or remove the field and bump the minor version of u3d.

@lacostej lacostej merged commit df93c33 into DragonBox:master Jan 8, 2019

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment