Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: ensure .upfile exists before attempting to create sample #40

Merged
merged 1 commit into from Dec 14, 2017

Conversation

lacostej
Copy link
Member

No description provided.

Copy link
Member

@niezbop niezbop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor nitpick, but it looks good to me.

@@ -44,7 +44,11 @@ protected void OnGUI()
#endif
scrollPosition = EditorGUILayout.BeginScrollView(scrollPosition);

if (!File.Exists(UpliftSettings.GetDefaultLocation()))
string SettingsLocation = UpliftSettings.GetDefaultLocation();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe settingsLocation ? It's the convention we used so far.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@lacostej lacostej merged commit 192bf77 into DragonBox:master Dec 14, 2017
@lacostej lacostej deleted the ensure_dotuplift branch December 14, 2017 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants