Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corgi cannot detect snippet with special character in title #41

Open
hminh0407 opened this issue Nov 17, 2018 · 0 comments
Open

Corgi cannot detect snippet with special character in title #41

hminh0407 opened this issue Nov 17, 2018 · 0 comments

Comments

@hminh0407
Copy link

hminh0407 commented Nov 17, 2018

Description

I've just figured that corgi does not support snippet title with special characters.

  • If a user create a snippet with special characters in title then it won't work because corgi cannot find its location.
  • User can delete this snippet manually but the snippet title still remain in the list of snippets. And it has to be manually deleted via .corgi/snippets.json

Expectation

  • User can input tile with special characters like (!@#$%^&*) and corgi can still detect it.
  • Or have a validation mechanic to warn the user not to break corgi functionality.
  • Or put a guide in the document about what to be expected for a snippet title

Reproduce step

  • create a snippet with special character in title. Ex: [utills][disk] display disk usage.
  • run any corgi command that trigger the snippet. Ex: corgi describe and choose above snippet from the list
  • corgi will throw error
Error: open .../snippet/[utils][disk]_display_disk_usage.json: no such file or directory
Snippets directory path: .../snippet, check if snippet file exists inside.
@hminh0407 hminh0407 changed the title Cannot remove snippet with special character in title Corgi cannot detect snippet with special character in title Nov 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant