Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release, major updates. #14

Merged
merged 2 commits into from Jul 10, 2019
Merged

Conversation

vladutilie
Copy link
Contributor

@vladutilie vladutilie commented Sep 26, 2018

Hello hello,

A friend of mine who uses WordPress Drift plugin asked me if I can make some improvments to this plugin and, why not, I accepted the challenge. Regarding this point I build or rebuild this awesome plugin these days and I am so excited saying this to you.

Here are the major changes of the plugin which I done:

As a bonus:

  • I changed the youtube video URL from readme file to this one;
  • I changed some links from HTTP to HTTPS in readme file;
  • I updated the changelog in readme file;
  • I translated the plugin in Romanian language and I will import the translations after you update the plugin on the WP repository;
  • I updated the licence to GPLv3;
  • I added Requires PHP: 4.1.0 in readme header file;
  • I fixed some typos.

In the versioning process, I considered the numbers above and I added the actual version (1.8.4) then resulted this version number 3.2.9.
1.8.4 +
1.4.5
equals
3.2.9
You are free to change the process of the versioning and change the version number from this release 馃槂.

In the end, please review my code, improvments and changes and if you agree with that accept my pull request. If there are some advices please tell me.

In the future I am willing to help with new features so if you want you can add me as a contributor to the WordPress plugin. My WP profile is here.

@vladutilie
Copy link
Contributor Author

Hello @dcancel,
Can someone review my code? Thanks a lot 馃憤

README.md Outdated Show resolved Hide resolved
@RollForReflex
Copy link
Contributor

Hey there @vladutilie! Thank you so much for making this (much needed) update to our Wordpress plugin (not to mention adding additional language support)!

I left a couple very small comments - once they're addressed I'd be glad to approve.

@vladutilie
Copy link
Contributor Author

Hey there @vladutilie! Thank you so much for making this (much needed) update to our Wordpress plugin (not to mention adding additional language support)!

I left a couple very small comments - once they're addressed I'd be glad to approve.

Hi @RollForReflex,

I've made the possible changes you reported to me and another some changes to the plugin like WPCS review and improving method documentations.

Best regards,
Vlad

@RollForReflex
Copy link
Contributor

@vladutilie looks good! Thanks!

@vladutilie vladutilie closed this Jul 2, 2019
@vladutilie vladutilie reopened this Jul 2, 2019
@RollForReflex
Copy link
Contributor

hey @vladutilie you're all set now!

@vladutilie
Copy link
Contributor Author

Hi @RollForReflex,
Thanks a lot. I hope it will be merged soon.

@vladutilie vladutilie closed this Jul 10, 2019
@vladutilie vladutilie reopened this Jul 10, 2019
@RollForReflex RollForReflex merged commit 0bc43c7 into Driftt:master Jul 10, 2019
@MisterSquishy MisterSquishy mentioned this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants